Skip to content

Fix RTD theme and perform some cleanup #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2023

Conversation

christophfroehlich
Copy link
Contributor

Something got broken with our RTD theme, e.g. no bullet points were rendered for lists.

It seems that the way how the theme is installed here is deprecated. I do not know if there were made some custom adaptions to the theme, so I just copied the theme.css from the latest version.

I also did some reformatting of the rst files, as well as restructuring the TOC etc: More PRs from the linked repos will follow.

See the differences from the old layout (left) to the new one:

image

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting the deprecation and updating it! No it wasn't customized and indeed I can definitely confess I am not friends with rst... Most files were converted from older markdown files and it shows

@bmagyar bmagyar merged commit 311a61a into ros-controls:master Apr 29, 2023
@christophfroehlich christophfroehlich deleted the cleanup branch April 29, 2023 09:15
@christophfroehlich
Copy link
Contributor Author

If the theme was not adapted at all, I'll try if I manage to get it installed properly via pip instead of copying the source into it.

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 29, 2023
* Cleanup conf.py

* Update RTD theme

* Reformat lists

* Fix trailing whitespace

(cherry picked from commit 311a61a)

# Conflicts:
#	doc/getting_started/getting_started.rst
#	doc/project_ideas.rst
christophfroehlich added a commit that referenced this pull request Apr 29, 2023
* Fix RTD theme and perform some cleanup (#82)

* Cleanup conf.py

* Update RTD theme

* Reformat lists

* Fix trailing whitespace

(cherry picked from commit 311a61a)

# Conflicts:
#	doc/getting_started/getting_started.rst
#	doc/project_ideas.rst

* Fix merge

---------

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants