Update directive.js #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return the custom date object rather than a javascript date object in the checkDate function. Add months in order rather than reversed. Update the original model on date change. Allow for a calculation in the "startYear" attribute. My Angular skills are limited as I am new to this but the fixes implemented resolve my personal needs - maybe someone smarter can fix this properly. There is also a bug on line 38 where "!date.month" will evaluate to true in the event that month is 0 (which it will be if January is selected) and that will cause the checkDate function to return false. I will resolve this shortly.
Additional update to fix checkDate bug where January would return an invalid date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the custom date object rather than a javascript date object in the checkDate function. Add months in order rather than reversed. Update the original model on date change. Allow for a calculation in the "startYear" attribute.
My Angular skills are limited as I am new to this but the fixes implemented resolve my personal needs - maybe someone smarter can fix this properly.
There is also a bug on line 38 where "!date.month" will evaluate to true in the event that month is 0 (which it will be if January is selected) and that will cause the checkDate function to return false. I will resolve this shortly.