Revert "[Feature | BUG] - Handle lang attribute for all Othernames (#209

)" (#210) This reverts commit 1bd4466.
ror-community · Apr 12, 2024 · 5cdce5e · 5cdce5e
1 parent 1bd4466
commit 5cdce5e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 20 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -5,5 +5,5 @@ updates:
   - package-ecosystem: "npm"
     directory: "/"
     schedule:
-      interval: "weekly"
-    target-branch: "dependabot-updates"
+      interval: "daily"
+    target-branch: "dev"
diff --git a/app/components/v2/organization-item.js b/app/components/v2/organization-item.js
@@ -20,7 +20,6 @@ export default Component.extend({
   lastModifiedDate: null,
   otherNames: null,
   organizationTypes: null,
-  configService: service('config-service'),
 
 
   // Convert label array into a dictionary with relationship type as key
@@ -46,15 +45,13 @@ export default Component.extend({
       return result;
     }, {});
 
-    for (let key in groupedNames) {
-      if (groupedNames[key]) {
-        groupedNames[key].forEach((item) => {
-          if (item.lang && !item.value.includes(`(${item.lang})`)) {
-            item.value = `${item.value} (${item.lang})`;
-          }
-        })
-      }
-    };
+    if (groupedNames.label) {
+      groupedNames.label.forEach((label) => {
+        if (label.lang && !label.value.includes(`(${label.lang})`)) {
+          label.value = `${label.value} (${label.lang})`;
+        }
+      });
+    }
 
     const values = Object.values(groupedNames).flat().map(item => item.value).join(', ');
 

diff --git a/app/services/config-service.js b/app/services/config-service.js
diff --git a/app/templates/components/v2/organization-item.hbs b/app/templates/components/v2/organization-item.hbs
@@ -139,7 +139,7 @@
             {{#link-to "organizations.show" model.id class="btn btn-sm btn-round"}}View details{{/link-to}}
           {{/if}}
           {{#if (not isSearch)}}
-            <p class="mt-3 mb-0"><i>Some record data is not displayed in this view. <a target="_blank" rel="noopener" href="{{configService.API_URL_V2}}/organizations/{{model.id}}">See JSON view for full record data</a></i></p>
+            <p class="mt-3 mb-0"><i>Some record data is not displayed in this view. <a target="_blank" rel="noopener" href="https://api.ror.org/v2/organizations/{{model.id}}">See JSON view for full record data</a></i></p>
             <p class="mt-3 mb-0">
               <i>
                 {{#if lastModifiedDate}}