-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nasapower #155
Comments
I was looking at the POWER website. The most, but not all, of the other POWER datasets have similar interfaces. It should be pretty simple add some of the Renewable Energy and Sustainable Buildings data to the package as well. I've just never used them for my work. It would be good if these were added, that someone with some knowledge of them could provide some assistance on what's useful. Happy to get feedback on that. |
Thanks @adamhsparks - Editors are discussing ... |
Editor checks:
Editor commentsThanks for your submission @adamhsparks Goodpractice output: ── 0 errors ✔ | 0 warnings ✔ | 0 notes ✔
♥ Aha! Astounding package! Keep up the best work! Seeking reviewers now. Reviewers: @alisonboyer @UniversalTourist |
Reviewers are @alisonboyer and @UniversalTourist - due date is 2017-12-06 |
Package ReviewPlease check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
DocumentationThe package includes all the following forms of documentation:
Functionality
Final approval (post-review)
Estimated hours spent reviewing: It took almost, totally, 4-5 hours to check everything. During that time I studied what is NASA-POWER, agroclimatology and read rOpenSci guidelines, learned about Travis-CI and running tests. Review CommentsThis is the first time I heard about NASA-POWER and it is a great data source for Earth scientists. These package provides a data frame output and it will make the data preparation process more easier than copy-pasting.
p.s This is my first time at reviewing a package and I hope I can be helpful :) |
thx very much for your review @UniversalTourist |
Thank you @UniversalTourist I have fixed the vignette text you noted where it said "which will which will", ropensci/nasapower@6dd0d9c. I have also added a link to other gridded climatology data sets. As far as I know, nothing really aligns with what NASA POWER offers at a higher resolution, but there are other gridded climatology data sets out there, ropensci/nasapower@8b8a11a |
Thank you very much! |
@alisonboyer Your review was due a few days ago. Can you get it in soon? |
Hi Scott,
I will get it to you today.
--Alison
…_________________________________
Alison Boyer
Research Staff, ORNL DAAC
Environmental Sciences Division
Oak Ridge National Laboratory
and
Joint Faculty Assistant Professor
Dept. of Ecology & Evolutionary Biology
University of Tennessee
Knoxville, Tennessee 37996
http://www.bio.utk.edu/boyer/index.html
On Fri, Dec 8, 2017 at 12:03 PM, Scott Chamberlain ***@***.*** > wrote:
@alisonboyer <https://github.com/alisonboyer> Your review was due a few
days ago. Can you get it in soon?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#155 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALFI17sJddg7GMNN-maEZGDnhuB_pUJzks5s-Wv1gaJpZM4QR_1M>
.
|
thanks @alisonboyer |
Package Review As the reviewer I confirm that there are no conflicts of interest for me to review this work (If you are unsure whether you are in conflict, please speak to your editor before starting your review). The package includes all the following forms of documentation:
Functionality
Estimated hours spent reviewing: 2.5 Review Comments: Providing a recommended citation for the data is very nice. Does the data have a DOI? |
Thank you, @alisonboyer. I didn't have a statement about performance because it will vary by the data requested and Internet connection. However, I ran an example this morning and added a statement to the vignette in this commit, ropensci/nasapower@3bab17e about what some possible realistic times and data frame sizes could be for this. See starting at line 114 in the nasapower.Rmd vignette for the statement. AFAIK there is no DOI for the POWER data. As you noted, I've included their statement about how they wish to be acknowledged and the link to https://power.larc.nasa.gov/documents/Agroclimatology_Methodology.pdf is included in the documentation in several locations as well. |
For both @UniversalTourist and @alisonboyer, I've also expanded the documentation in the vignette to provide an example of how to turn the data frame in to a https://adamhsparks.github.io/nasapower/articles/nasapower.html#creating-spatial-objects |
This afternoon the POWER webpage stopped serving data. I've added a check now that pings the server first, five times, to see if it's responding, before proceeding with the request. If the reviewers could check this as it was added after both reviews? |
Hey Adam! Cheers. |
@UniversalTourist, please wait. Now that it's responding again, it's clear that my fix didn't work. I need to find a new way. |
OK, fixed now with a new better way of doing checking whether the NASA - POWER site is serving data or not. Sorry about that. |
@alisonboyer can you get another review in within a week ? if not no worries and we'll move on |
Hi Scott,
i'm really sorry but I don't think I'm able to review it at this time.
Please don't wait for me.
…_________________________________
Alison Boyer
Research Staff, ORNL DAAC
Environmental Sciences Division
Oak Ridge National Laboratory
and
Joint Faculty Assistant Professor
Dept. of Ecology & Evolutionary Biology
University of Tennessee
Knoxville, Tennessee 37996
http://www.bio.utk.edu/boyer/index.html
On Tue, Aug 21, 2018 at 7:13 PM Scott Chamberlain ***@***.***> wrote:
@alisonboyer <https://github.com/alisonboyer> can you get another review
in within a week ? if not no worries and we'll move on
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#155 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALFI10cnSKP2y7KklgS5jgjN-F2XQ5Sxks5uTJQqgaJpZM4QR_1M>
.
|
Package Review
DocumentationThe package includes all the following forms of documentation:
Good idea to add guidelines for users on how to contribute. See e.g. https://github.com/ropensci/dotgithubfiles/ Functionality
Final approval (post-review)
Estimated hours spent reviewing: 1Review Commentsawesomeness:
other comments:
create_icasa(lonlat = c(151.81, -27.48),
dates = c("1985-01-01", "1985-12-31")
)
Error in if (substr(file_out, nchar(file_out) - 3, nchar(file_out)) != :
argument is of length zero |
Thanks @sckott, I'll address your comments shortly. |
@sckott, did you have any thoughts on the fact that |
I'm sure I have some fxns that return different objects depending on user inputs, but it definitely seems better to avoid that. Maybe one of these two optoins:
|
I've some ideas of what can be done with it. I'll think on it some more and see what I can implement. At this point I think I've addressed everything else you've pointed out above. |
should I wait on this for this submission, or do you mean more in the long term? |
No, please wait, I've pushed a custom |
will do. |
Hi @sckott, I think it's ready for you to check and hopefully accept. I've found and squashed several more bugs while dealing with the metadata and your suggestions. cheers! |
@adamhsparks a few things:
Its essential that your examples run successfully. a good way to do this is have them run on travis, e.g. https://github.com/ropensci/wellknown/blob/master/.travis.yml#L28 Please make sure your examples work moving forward |
Thanks @sckott, I'll address these issues. I've not seen that Travis configuration before, that's useful! |
Hi @sckott, after that embarrassing blunder, I've corrected the examples and a few other issues to align with rOpenSci guidelines if you'd like to have a look. Thanks again for the suggestion with Travis to build examples, it caught yet another error for me even after I'd fixed everything once! |
nice, glad it was helpful. having another quick look |
Approved! Thanks again for your submission @adamhsparks !
|
Hi @adamhsparks ! You know the blog post drill from https://ropensci.org/blog/2017/04/04/gsodr/ 😄. Are you interested in doing one, or a tech note on Tech Notes can be published at any time, while we publish blog posts about packages weekly. Right now Tuesday 2018-10-16 or subsequent Tuesdays are available for blog posts. If you're interested, let me know your preferred publication date and then please submit via pull request a week prior. Guidelines are here: https://github.com/ropensci/roweb2#contributing-a-blog-post |
Excellent! I'm tidying up a few remaining issues and will transfer it over shortly. @sckott and @stefaniebutland, yes, we should do a proper blog post about this one. I'll get something together and submit a PR next month. Thank you all, once again, for the support and motivation. This package has been a long-time coming, but I'm super happy with the condition it's now in before it even reaches CRAN (which will hopefully happy soon as well). |
Ok, I've transferred ownership and once again lost the ability to edit the webpage and the tags associated with the repository so the webpage link incorrectly points to my personal repository, still, as I forgot to change that before transferring it over. Can I get the right permissions to edit the repository details, etc.? ta! |
nice work adam! |
done |
Summary
nasapower automates downloading NASA-POWER agroclimatology data in your R
session as a tidy data frame for analysis, modelling or other purposes by interfacing with the NASA POWER API. POWER (Prediction Of Worldwide Energy Resource) data are freely available for download through a web interface at a resolution of 0.5˚ longitude by 0.5˚ latitude.
https://github.com/adamhsparks/nasapower
data retrieval and extraction, nasapower automates downloading and parsing
NASA - POWER data into a useful format in R using the POWER API.
Researchers who use NASA - POWER for modelling or other purposes though there may
be others that I'm not familiar with. This is the audience I know best since
I'm part of it and use these data for my own work.
yours differ or meet our criteria for best-in-category?
Since the POWER API is brand new, no. This is the first R package to utilise it's capabilities.
Requirements
Confirm each of the following by checking the box. This package:
Publication options
paper.md
matching JOSS's requirements with a high-level description in the package root or ininst/
.Detail
Does
R CMD check
(ordevtools::check()
) succeed? Paste and describe any errors or warnings:Does the package conform to rOpenSci packaging guidelines? Please describe any exceptions:
If possible, please provide recommendations of reviewers - those with experience with similar packages and/or likely users of your package - and their GitHub user names:
I've picked on everyone I can think of previously for other submissions.
The text was updated successfully, but these errors were encountered: