Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for TRUE / FALSE in #70 #73

Merged
merged 3 commits into from
May 8, 2021
Merged

Fix for TRUE / FALSE in #70 #73

merged 3 commits into from
May 8, 2021

Conversation

mmahmoudian
Copy link
Contributor

In this PR the issue raised by rOpenSci reviewer (ropensci/software-review#386 (comment)) regarding the following comment was addressed and resolve the "TRUE / FALSE" point in issue #70 :

For the parameters in write_ods() that take a TRUE/FALSE value, I'd like to see the default value to be explicitly stated here in the documentation.

Additionally, the following documentation fixes has been done:

  • Added "logical" to all binary arguments to have more uniform documentation style
  • Order or of arguments in documentation now match the function

@chainsawriot chainsawriot merged commit 8dff160 into ropensci:master May 8, 2021
@chainsawriot
Copy link
Collaborator

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chainsawriot chainsawriot chainsawriot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmahmoudian @chainsawriot