-
Notifications
You must be signed in to change notification settings - Fork 63
Fix link to R Packages book #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fkohrt , can you please just put " code.html" in lower case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Oh sorry, i just tried "code.html" manually, and didn't see a re-direct. Can you then please run the {urlchecker} package on it, to get the correct version and update if needed? |
Sorry, my previous comment was technically not correct: Netlify makes the file available under both names, so no HTTP redirects are happening (and thus, {urlchecker} doesn't care). Still, I believe the original file name is the best choice in case Netlify is ever replaced by a different host.er |
So, with your approval I will revert bfced34 |
See discussion at ropensci#498
@mpadge This can be merged. |
Thanks @fkohrt, can you please just add a line to the changelog, and reference this PR? I'll merge then. Thank you. |
No description provided.