-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STP above 1000 is set to 1000-STP? #117
Comments
have just downloaded 2013.tar.gz from the source, it has STP code this way - ie with small values that look like they should be over 999.9, but then SLP (sea level pressure) seems to range freely over 999.9 so I'm not sure how (if?) missing values are encoded in SLP. Documetation is sparse... |
Using GSODtools https://github.com/environmentalinformatics-marburg/GSODTools data values for STP that are eg 7.4 are returned as 1007.4 so it looks like a 1000 offset. GSODtools downloads a gzipped fixed-width file via ftp: Link: ftp://ftp.ncdc.noaa.gov/pub/data/gsod/2013/032380-99999-2013.op.gz
whereas GSODR gets a CSV from an https address... I think its a processing fault at the GSOD end... |
Thanks for letting me know about this, @barryrowlingson. |
@barryrowlingson Copying from the ISD format document: That being said, I believe @adamhsparks is on it, see d8ea9fd and following 😉 |
Thanks, @fdetsch. The GSOD README does not say anything about a scaling factor. In the Overview it just says:
In the DETAILS/FORMAT it has:
So there's nothing about scaling in the data here. Something is up as @barryrowlingson suggests with the processing to create the CSV file. |
Directly from the CSV, they've somehow lopped off the "1" for values >1000 and just provided a text column with leading zeros. Note that the SLP is not affected by this.
|
The new release, https://github.com/ropensci/GSODR/releases/tag/v4.1.0, should be on CRAN very shortly with this bug fix. |
STP values typically range around the 1000 milibars value, but it seems that values over around 1000 are wrapped back to zero. At least for the site data I've got. This might be because somewhere 999.9 is being used as a missing value, but when true values of 999.9 are possible these are instead set to 0, so that 999.9 = 0 and 1000 =0.1? That's a guess.... STP of 0 (anything below 800s) are physically impossible...
Example:
Shows a scatter plot with numbers up in the high 900s and some in the low tens...
Fix could be to add 1000 (or is it 999.9?) to any values below 500. Maybe some docs on the source web site about this, maybe I'll download the raw data later and see...
The text was updated successfully, but these errors were encountered: