Remove wordwrap for links so they don't break (on mobile and smaller#64
Open
unkrich wants to merge 1 commit intorootvc:mainfrom
Open
Remove wordwrap for links so they don't break (on mobile and smaller#64unkrich wants to merge 1 commit intorootvc:mainfrom
unkrich wants to merge 1 commit intorootvc:mainfrom
Conversation
screen sizes) The current implementation of wordwrap is only used in the case of a link. At which point it checks against a maxWidth of 76 and breaks the link, and/or inserts a newline character if whitespace is found. Introducing a newline character breaks the link and is seemingly unnecessary (may have to do with addonFit). Introducing a newline on whitespace character is also seemingly unecessary as a URL should not have a whitespace character anywhere but possibly the end of the string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
screen sizes)
The current implementation of wordwrap is only used in the case of a link. At which point it checks against a maxWidth of 76 and breaks the link, and/or inserts a newline character if whitespace is found.
Introducing a newline character breaks the link and is seemingly unnecessary (may have to do with addonFit).
Introducing a newline on whitespace character is also seemingly unecessary as a URL should not have a whitespace character anywhere but possibly the end of the string.
Possible fix for #38 and #42 (the latter issue is less clear).
One possible oversight is that wordwrap may be useful for the case where a string with multiple URLs passed in separated by a whitespace character that should actually be a newline is missed. This doesn't appear to be a problem.