Skip to content

Ask if you don't understand something #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: ehancement/code-review-best-practices
Choose a base branch
from
Draft

Ask if you don't understand something #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f73968
create example for asking
adlamas Sep 25, 2023
a57c096
change spaces
adlamas Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions code-review/examples/ask.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@

class PeopleService
def process_people
People.connection.execute(
Copy link
Author

@adlamas adlamas Oct 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give me a brief explanation about what this query is meant to do? Thanks in advance

"UPDATE people SET name = CONCAT(name, ' ', surname), enabled = TRUE WHERE created_at <= '#{2.years.ago}'"
)
end
end