Enhancement/libraries updates #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated crashlytics updated build graddle added view binding
removed deprecated code
agustinkoll-rootstrap
requested review from
amaury901130,
jjszolno,
mato2593 and
ximenaperez
as code owners
amaury901130
reviewed
Feb 4, 2021
Comment on lines
28
to
32
| when (message) { | ||
| "" -> builder.setMessage(context.getString(R.string.generic_error)) | ||
| null -> builder.setMessage(context.getString(R.string.generic_error)) | ||
| else -> builder.setMessage(message) | ||
| } |
There was a problem hiding this comment.
try with message.isNullOrEmpty()
Suggested change
| when (message) { | |
| "" -> builder.setMessage(context.getString(R.string.generic_error)) | |
| null -> builder.setMessage(context.getString(R.string.generic_error)) | |
| else -> builder.setMessage(message) | |
| } | |
| message = if(message.isNullOrEmpty()) | |
| context.getString(R.string.generic_error) | |
| else | |
| message | |
| builder.setMessage(message) | |
ximenaperez
approved these changes
Feb 4, 2021
mato2593
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in
removed deprecated crashlytics
updated libraries
moved dialog logic to an object