Feature/corutines network layer #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury901130
requested review from
jjszolno,
mato2593 and
ximenaperez
as code owners
ximenaperez
reviewed
Dec 17, 2020
| networkState = NetworkState.idle | ||
| networkState = NetworkState.error | ||
| } | ||
| private fun mangeError(exception: Throwable?) { |
There was a problem hiding this comment.
there's a typo in the method name, it should be manageError
ximenaperez
reviewed
Dec 17, 2020
| @Subscribe | ||
| fun signedUpFailure(event: FailureEvent) { | ||
| error = null | ||
| private fun mangeError(exception: Throwable?) { |
ximenaperez
reviewed
Dec 17, 2020
| class FailureEvent | ||
| enum class ApiErrorType { | ||
| apiError, | ||
| uknownError |
There was a problem hiding this comment.
there's a typo here, it should be "unknown"
ximenaperez
suggested changes
Dec 17, 2020
ximenaperez
approved these changes
Dec 17, 2020
mato2593
approved these changes
Dec 18, 2020
| response.errorBody()?.let { | ||
| val error = Gson().fromJson(it.charStream(), ErrorModel::class.java) | ||
| bus.post(ErrorEvent(ErrorUtil.handleCustomError(error))) | ||
| private fun <T> manageResponse(response: Response<T>): Result<Data<T>> { |
There was a problem hiding this comment.
IMO, handleResponse is a more accurate name of what we are doing here. The same would apply for the other manageSomething functions.
| networkState = NetworkState.idle | ||
| networkState = NetworkState.error | ||
| networkState = NetworkState.idle | ||
| state = SignUpState.signedUpSuccess |
There was a problem hiding this comment.
I know this is old, but it should be either signUpSuccess or signedUpSuccessfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Official doc:
https://developer.android.com/topic/libraries/architecture/coroutines
Issue: Add Kotlin Coroutines