Add utils class. #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury901130
force-pushed
the
enhancement/add-utils-class
branch
from
0445df8 to
d103a3e
Compare
mato2593
reviewed
May 6, 2019
| /.idea/workspace.xml | ||
| /.idea/navEditor.xml | ||
| /.idea/assetWizardSettings.xml | ||
| /.idea/* |
There was a problem hiding this comment.
Did you also remove the files from git?
There was a problem hiding this comment.
only has the initial commit files.
There was a problem hiding this comment.
But the files that I commented in the previous PR that should be deleted doesn't appear as deleted in this PR. So you still have to delete those from git I think
| * } | ||
| * */ | ||
|
|
||
| var ioThread: Executor = IoThreadExecutor() |
There was a problem hiding this comment.
Indentation seems to be wrong
amaury901130
force-pushed
the
enhancement/add-utils-class
branch
from
3a35be8 to
21b0ae2
Compare
amaury901130
force-pushed
the
enhancement/add-utils-class
branch
from
21b0ae2 to
2beb691
Compare
ximenaperez
reviewed
May 8, 2019
| * @param regex Regex string function to validate with Pattern.matches | ||
| * @return Boolean : true if pattern match | ||
| * */ | ||
| fun String.validate(regex: String): Boolean = Pattern.matches(regex,this) |
ximenaperez
reviewed
May 8, 2019
| fun Long.getDate(): DateTime = DateTime(this, DateTimeZone.UTC) | ||
| fun DateTime.getLong(): Long = this.millis | ||
| fun Any.toGson(): String = Gson().toJson(this) | ||
| inline fun <reified T> String.fromGson() : T = Gson().fromJson(this,T :: class.java) |
amaury901130
requested review from
ximenaperez and
mato2593
and removed request for
ximenaperez
ximenaperez
approved these changes
May 10, 2019
amaury901130
added
invalid
hrodrick
added a commit
that referenced
this pull request
Apr 21, 2022
Sync Master-koin from original repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AppExecutors: android executors thread background and the main thread.
Converter: converter class.
Simple call back for action events.
Validator: basic validations.
TinyDb: Util class for shared preferences and save local data like images or other binaries files.