Rename Events to ActiveOutbox::Events to avoid conflicts. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Issue was raised that the Events const name was pretty common and this could cause conflicts. * Added false in const_defined so it won't lookup to ancestors.
guillermoap
changed the title
guillermoap
requested review from
JoDaBaRo,
mwolman and
santiagodiaz
as code owners
santib
reviewed
Apr 25, 2024
| @@ -10,16 +10,21 @@ module Outboxable | |||
| *namespace, klass = name.underscore.upcase.split('/') | |||
| namespace = namespace.reverse.join('.') | |||
|
|
|||
| module_parent.const_set('Events', Module.new) unless module_parent.const_defined?('Events') | |||
| module_parent.const_set('ActiveOutbox', Module.new) unless module_parent.const_defined?('ActiveOutbox', false) | |||
There was a problem hiding this comment.
what is module_parent ? is it configurable?
What I was saying is that any class created by this gem should go in ::ActiveOutbox namespace
There was a problem hiding this comment.
that would be the module name of where this concern is included. That we are not creating ourselves
There was a problem hiding this comment.
hmm ok, I think we are good then
santib
approved these changes
Apr 25, 2024
JulianPasquale
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was raised that the Events const name was pretty common and this could cause conflicts.
Added false in const_defined so it won't lookup to ancestors fixing Fix an issue with finding the Events module for namespaced models #21