Fix Buffer deprecations #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doubleface
pushed a commit
to konnectors/libs
that referenced
this pull request
Jan 24, 2022
Integration of rootslab/toni#1 in our own version of the toni lib We need this to avoid a massive load of warning messages in konnector logs for each konnector execution.
doubleface
pushed a commit
to konnectors/libs
that referenced
this pull request
Feb 4, 2022
To avoid a node deprecation warning in geco toni sub dependency We tried a PR into toni a long time ago without any result rootslab/toni#1
doubleface
pushed a commit
to konnectors/libs
that referenced
this pull request
Feb 4, 2022
To avoid a node deprecation warning in geco toni sub dependency We tried a PR into toni a long time ago without any result rootslab/toni#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Node v12, using the Buffer constructor is deprecated. Since causes deprecation warnings when using toni on Node v12.
This PR intends to replace Buffer constructor usages by methods recommended by the docs. I'm no expert about buffers at all, so I just followed the documentations and checked that tests are still passing.