Extract Playbook struct
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangrufus
force-pushed
the
playbook-struct
branch
2 times, most recently
from
6d25aa0 to
2cf4c7d
Compare
swalkinshaw
reviewed
Jan 5, 2020
tangrufus
added a commit
to tangrufus/trellis-cli
that referenced
this pull request
Jan 6, 2020
… & \`AdHocPlaybook\`; Remove \`PlaybookRunner.SetFiles\` roots#91 (comment) roots#91 (comment) roots#91 (comment)
tangrufus
force-pushed
the
playbook-struct
branch
from
2cf4c7d to
1fe1b2f
Compare
tangrufus
added a commit
to tangrufus/trellis-cli
that referenced
this pull request
Jan 6, 2020
… & \`AdHocPlaybook\`; Remove \`PlaybookRunner.SetFiles\` roots#91 (comment) roots#91 (comment) roots#91 (comment)
tangrufus
force-pushed
the
playbook-struct
branch
from
1fe1b2f to
b5dd7b5
Compare
tangrufus
added a commit
to tangrufus/trellis-cli
that referenced
this pull request
Jan 6, 2020
|
Looks great 👍 I'll try and test soon |
swalkinshaw
reviewed
Jan 18, 2020
swalkinshaw
reviewed
Jan 18, 2020
swalkinshaw
reviewed
Jan 18, 2020
|
Other than the one |
… & \`AdHocPlaybook\`; Remove \`PlaybookRunner.SetFiles\` roots#91 (comment) roots#91 (comment) roots#91 (comment)
tangrufus
force-pushed
the
playbook-struct
branch
from
392210c to
0c2ec85
Compare
swalkinshaw
approved these changes
Jan 20, 2020
swalkinshaw
reviewed
Jan 20, 2020
tangrufus
force-pushed
the
playbook-struct
branch
3 times, most recently
from
5532f99 to
b1b1d8d
Compare
tangrufus
force-pushed
the
playbook-struct
branch
from
b1b1d8d to
6eab9f3
Compare
swalkinshaw
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #72 (comment)
Although all tests passed, need help on testing the commands manually to check for unwated (and not covered by tests) issues.