Conversation
Member
|
Thanks for the fix. Could you update this to avoid Ideally rewrite only the stale host, preserve the path/query, and add tests for subdomain + subdirectory multisite |
…multisite and add subdomain/subdirectory tests
Author
|
@retlehs Updated, thank you for the feedback! assetPath() now uses a private rewriteHost() helper that takes only the scheme/host/port from See the changes here:
I also added tests for single-site passthrough, subdomain multisite, and subdirectory multisite. |
QWp6t
reviewed
Jun 18, 2026
Co-authored-by: QWp6t <QWp6t@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a WordPress multisite network, the @Vite directive generates asset tags pointing to the main site's domain instead of the current subsite's domain, causing CORS errors on subsites. This issue has also been discussed on Roots Discourse.
Vite::assetPath() resolves the URI from assets.manifests.*.url, which is set once at boot from get_theme_file_uri() and never reflects the active subsite context.
home_url()returns the correct origin for the currently active site. The fix is scoped tois_multisite()so single-site installs are completely unaffected.