Skip to content
This repository was archived by the owner on Oct 9, 2020. It is now read-only.

Added libattr fallback from ENOATTR to ENODATA in fake_id0… #6

Conversation

mgoltzsche
Copy link

… to support builds on fedora.

Builds on fedora can be run by unprivileged users with plain runc: https://github.com/mgoltzsche/cntnr/blob/a2b00584af785413c8eb8dcc43676c148f47260f/Dockerfile
This change does not affect debian-based builds.

(I think in the same file <attr/xattr.h> could be replaced with <sys/xattr.h> removing the libattr dependency but I wasn't sure if this would also work in every other involved build environment.)

Signed-off-by: Max Goltzsche max.goltzsche@gmail.com

… build on fedora.

Signed-off-by: Max Goltzsche <max.goltzsche@gmail.com>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgoltzsche
Copy link
Author

@AkihiroSuda Unfortunately the Travis CI build failed because it cannot install libprotobuf-c-dev. Something seems to be wrong with the travis build image. Could you have a look please?

@AkihiroSuda AkihiroSuda merged commit f4dc8cb into rootless-containers:rootlesscontainers Sep 25, 2018
@AkihiroSuda
Copy link
Member

Thanks, will look into next week

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants