Skip to content

Conversation

@vishnurk6247
Copy link
Member

@vishnurk6247 vishnurk6247 commented Dec 13, 2025

Summary by CodeRabbit

  • New Features

    • Added new API methods for managing authenticators, models, and telephony configurations.
    • Added comprehensive development tooling setup with Prettier code formatting, ESLint linting, and TypeScript type checking.
  • Chores

    • Updated development environment configuration with new workspace setup and VSCode settings.
    • Updated CI/CD workflow by removing legacy linting step.
    • Refactored codebase for consistency in code style and formatting.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Large-scale refactoring of the wavefront client project, standardizing string quotes from double to single across all service and component files, adding development tooling (Prettier, ESLint), introducing new API methods, and making minor layout and accessibility improvements.

Changes

Cohort / File(s) Summary
CI/Build Configuration
.github/workflows/build-project.yml, .pre-commit-config.yaml
Removed Ruff pre-commit linting from CI workflow; replaced single Ruff configuration with structured list adding ESLint, TypeScript checking, and Prettier hooks for JavaScript/TypeScript files.
Development Environment Setup
install-dep-local.sh, wavefront.code-workspace, .vscode/*, flo_ai/.vscode/*, wavefront/.vscode/*
Added local dependency installation script orchestrating uv and pnpm installs; created VSCode workspace file and settings files for Python/TypeScript tooling; added VSCode extension recommendations.
Client Tooling Configuration
wavefront/client/.env, wavefront/client/.prettierrc.json, wavefront/client/.prettierignore, wavefront/client/package.json
Updated environment variables (VITE_BASE_URL and VITE_APP_ENV); added Prettier config with Tailwind plugin and ignore patterns; added npm scripts for format, typecheck, and preview; added Prettier and ESLint plugins as dev dependencies.
API Service Files (Quote Normalization)
wavefront/client/src/api/*-service.ts
Standardized string quotes from double to single across all 20+ service files; added new methods: deleteAuthenticator, getModel, updateMessageProcessor, listAllTelephonyConfigs; reformatted method signatures and parameter lists with minimal behavioral changes.
Component & UI Files (Quote & Class Reordering)
wavefront/client/src/components/*, wavefront/client/src/components/ui/*
Normalized string quotes to single quotes; reordered Tailwind CSS utility classes for consistency; added focus outline and accessibility attributes (aria-label, aria-checked, role) to various components; adjusted padding and positioning class sequences.
Hooks & Query Management
wavefront/client/src/hooks/data/*, wavefront/client/src/config/env.ts, wavefront/client/src/lib/*
Standardized quote style and empty string initialization across query functions, mutation hooks, and utilities; added getAppByIdKey to exports; updated default string values and literal type unions to single quotes.
Page Components
wavefront/client/src/pages/*
Comprehensive quote normalization and minor refactoring across 30+ page files; added polling logic in create app flow; introduced deletion confirmation dialogs; improved namespace handling; reordered Tailwind classes; added new route and state handlers.
Router & Type Changes
wavefront/client/src/router/index.tsx
Modified ChildrenRoute interface to require element: ReactNode and added optional path?: string; adjusted path handling and route rendering logic.
HTML & CSS
wavefront/client/index.html, wavefront/client/src/index.css
Minor HTML indentation/structure reformatting; updated CSS @import and @font-face quotes to single quotes.
Other Configuration
wavefront/client/src/App.tsx, wavefront/client/src/assets/icons/index.ts, wavefront/client/src/pages/apps/schemas.ts
Quote normalization in imports and string literals; no functional changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~35 minutes

  • Files affected: 120+ files across multiple domains (services, components, pages, config)
  • Pattern repetition: High homogeneity in quote normalization and class reordering reduces cognitive load
  • Functional additions: Scattered new API methods, polling logic, interface changes, and deletion flows require closer inspection
  • Areas of focus:
    • Router interface change in wavefront/client/src/router/index.tsx (affects type contract)
    • New methods in API services: deleteAuthenticator, getModel, updateMessageProcessor, listAllTelephonyConfigs
    • Polling logic addition in wavefront/client/src/pages/apps/create.tsx
    • Deletion confirmation dialog integrations across multiple page files
    • ChildrenRoute interface changes and their cascading impact on layout and route rendering

Possibly related PRs

Suggested reviewers

  • vizsatiz

Poem

🐰 Quotes dance from double to single with grace,
Prettier and ESLint fall into place,
New methods emerge, the services shine bright,
Tailwind classes reordered just right,
A refactor so grand, the client takes flight!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/setup-workspace

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 982f777 and c74ff27.

⛔ Files ignored due to path filters (1)
  • wavefront/client/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (107)
  • .github/workflows/build-project.yml (0 hunks)
  • .pre-commit-config.yaml (1 hunks)
  • .vscode/extensions.json (1 hunks)
  • .vscode/launch.json (0 hunks)
  • flo_ai/.vscode/settings.json (1 hunks)
  • install-dep-local.sh (1 hunks)
  • wavefront.code-workspace (1 hunks)
  • wavefront/.vscode/settings.json (1 hunks)
  • wavefront/client/.env (1 hunks)
  • wavefront/client/.prettierignore (1 hunks)
  • wavefront/client/.prettierrc.json (1 hunks)
  • wavefront/client/index.html (1 hunks)
  • wavefront/client/package.json (3 hunks)
  • wavefront/client/src/App.tsx (1 hunks)
  • wavefront/client/src/api/agent-service.ts (3 hunks)
  • wavefront/client/src/api/api-service-service.ts (2 hunks)
  • wavefront/client/src/api/app-service.ts (2 hunks)
  • wavefront/client/src/api/authenticator-service.ts (4 hunks)
  • wavefront/client/src/api/console-auth-service.ts (2 hunks)
  • wavefront/client/src/api/data-pipeline-service.ts (4 hunks)
  • wavefront/client/src/api/datasources-service.ts (5 hunks)
  • wavefront/client/src/api/knowledge-base-service.ts (4 hunks)
  • wavefront/client/src/api/llm-inference-service.ts (2 hunks)
  • wavefront/client/src/api/message-processor-service.ts (3 hunks)
  • wavefront/client/src/api/model-inference-service.ts (4 hunks)
  • wavefront/client/src/api/namespace-service.ts (2 hunks)
  • wavefront/client/src/api/stt-config-service.ts (3 hunks)
  • wavefront/client/src/api/telephony-config-service.ts (2 hunks)
  • wavefront/client/src/api/tool-service.ts (1 hunks)
  • wavefront/client/src/api/tts-config-service.ts (3 hunks)
  • wavefront/client/src/api/user-service.ts (1 hunks)
  • wavefront/client/src/api/voice-agent-service.ts (3 hunks)
  • wavefront/client/src/api/workflow-service.ts (6 hunks)
  • wavefront/client/src/assets/icons/index.ts (1 hunks)
  • wavefront/client/src/components/AppCard.tsx (3 hunks)
  • wavefront/client/src/components/ChatBot.tsx (12 hunks)
  • wavefront/client/src/components/DashboardLayout.tsx (5 hunks)
  • wavefront/client/src/components/InferencePopup.tsx (1 hunks)
  • wavefront/client/src/components/ProtectedLayout.tsx (2 hunks)
  • wavefront/client/src/components/ResourceCard.tsx (1 hunks)
  • wavefront/client/src/components/topbar/Topbar.tsx (4 hunks)
  • wavefront/client/src/components/ui/alert-dialog.tsx (1 hunks)
  • wavefront/client/src/components/ui/alert.tsx (1 hunks)
  • wavefront/client/src/components/ui/breadcrumb.tsx (1 hunks)
  • wavefront/client/src/components/ui/checkbox.tsx (1 hunks)
  • wavefront/client/src/components/ui/command.tsx (3 hunks)
  • wavefront/client/src/components/ui/dialog.tsx (3 hunks)
  • wavefront/client/src/components/ui/dropdown-menu.tsx (5 hunks)
  • wavefront/client/src/components/ui/empty.tsx (2 hunks)
  • wavefront/client/src/components/ui/field.tsx (2 hunks)
  • wavefront/client/src/components/ui/input.tsx (1 hunks)
  • wavefront/client/src/components/ui/label.tsx (1 hunks)
  • wavefront/client/src/components/ui/select.tsx (3 hunks)
  • wavefront/client/src/components/ui/separator.tsx (1 hunks)
  • wavefront/client/src/components/ui/slider.tsx (1 hunks)
  • wavefront/client/src/components/ui/switch.tsx (1 hunks)
  • wavefront/client/src/components/ui/tabs.tsx (2 hunks)
  • wavefront/client/src/components/ui/textarea.tsx (1 hunks)
  • wavefront/client/src/config/env.ts (1 hunks)
  • wavefront/client/src/hooks/data/fetch-hooks.ts (16 hunks)
  • wavefront/client/src/hooks/data/mutation-functions.ts (1 hunks)
  • wavefront/client/src/hooks/data/mutation-hooks.ts (4 hunks)
  • wavefront/client/src/hooks/data/query-functions.ts (8 hunks)
  • wavefront/client/src/hooks/data/query-keys.ts (1 hunks)
  • wavefront/client/src/index.css (2 hunks)
  • wavefront/client/src/lib/axios.ts (3 hunks)
  • wavefront/client/src/lib/constants.ts (1 hunks)
  • wavefront/client/src/lib/utils.ts (3 hunks)
  • wavefront/client/src/not-found/index.tsx (2 hunks)
  • wavefront/client/src/pages/apps/[appId]/agents/[id].tsx (18 hunks)
  • wavefront/client/src/pages/apps/[appId]/agents/index.tsx (5 hunks)
  • wavefront/client/src/pages/apps/[appId]/api-services/[id].tsx (44 hunks)
  • wavefront/client/src/pages/apps/[appId]/api-services/index.tsx (6 hunks)
  • wavefront/client/src/pages/apps/[appId]/authenticators/CreateAuthenticatorDialog.tsx (1 hunks)
  • wavefront/client/src/pages/apps/[appId]/authenticators/[authId].tsx (17 hunks)
  • wavefront/client/src/pages/apps/[appId]/datasources/YamlCreation.tsx (6 hunks)
  • wavefront/client/src/pages/apps/[appId]/datasources/YamlView.tsx (14 hunks)
  • wavefront/client/src/pages/apps/[appId]/datasources/[datasourceId].tsx (10 hunks)
  • wavefront/client/src/pages/apps/[appId]/datasources/index.tsx (5 hunks)
  • wavefront/client/src/pages/apps/[appId]/functions/[functionId].tsx (2 hunks)
  • wavefront/client/src/pages/apps/[appId]/functions/index.tsx (7 hunks)
  • wavefront/client/src/pages/apps/[appId]/knowledge-bases/CreateKnowledgeBaseDialog.tsx (1 hunks)
  • wavefront/client/src/pages/apps/[appId]/knowledge-bases/[kbId]/index.tsx (3 hunks)
  • wavefront/client/src/pages/apps/[appId]/knowledge-bases/index.tsx (7 hunks)
  • wavefront/client/src/pages/apps/[appId]/llm-inference/[configId].tsx (3 hunks)
  • wavefront/client/src/pages/apps/[appId]/llm-inference/index.tsx (7 hunks)
  • wavefront/client/src/pages/apps/[appId]/model-inference/[modelId].tsx (10 hunks)
  • wavefront/client/src/pages/apps/[appId]/model-inference/index.tsx (6 hunks)
  • wavefront/client/src/pages/apps/[appId]/pipelines/[pipelineId].tsx (8 hunks)
  • wavefront/client/src/pages/apps/[appId]/pipelines/create.tsx (5 hunks)
  • wavefront/client/src/pages/apps/[appId]/pipelines/index.tsx (12 hunks)
  • wavefront/client/src/pages/apps/[appId]/voice-agents/CreateVoiceAgentDialog.tsx (3 hunks)
  • wavefront/client/src/pages/apps/[appId]/voice-agents/EditVoiceAgentDialog.tsx (3 hunks)
  • wavefront/client/src/pages/apps/[appId]/workflows/[id].tsx (26 hunks)
  • wavefront/client/src/pages/apps/[appId]/workflows/index.tsx (5 hunks)
  • wavefront/client/src/pages/apps/[appId]/workflows/pipelines/[workflowPipelineId].tsx (17 hunks)
  • wavefront/client/src/pages/apps/[appId]/workflows/pipelines/index.tsx (6 hunks)
  • wavefront/client/src/pages/apps/create.tsx (6 hunks)
  • wavefront/client/src/pages/apps/edit/[appId].tsx (7 hunks)
  • wavefront/client/src/pages/apps/index.tsx (4 hunks)
  • wavefront/client/src/pages/apps/layout.tsx (4 hunks)
  • wavefront/client/src/pages/apps/schemas.ts (1 hunks)
  • wavefront/client/src/pages/forgot-password/index.tsx (2 hunks)
  • wavefront/client/src/pages/login/index.tsx (4 hunks)
  • wavefront/client/src/pages/logout/index.tsx (2 hunks)
  • wavefront/client/src/pages/reset-password/index.tsx (3 hunks)
  • wavefront/client/src/router/index.tsx (3 hunks)
⛔ Files not processed due to max files limit (21)
  • wavefront/client/src/router/routes.tsx
  • wavefront/client/src/store/notification-store.ts
  • wavefront/client/src/types/agent.ts
  • wavefront/client/src/types/api-service.ts
  • wavefront/client/src/types/app.ts
  • wavefront/client/src/types/authenticator.ts
  • wavefront/client/src/types/datasource.ts
  • wavefront/client/src/types/llm-inference-config.ts
  • wavefront/client/src/types/message-processor.ts
  • wavefront/client/src/types/pipeline.ts
  • wavefront/client/src/types/stt-config.ts
  • wavefront/client/src/types/telephony-config.ts
  • wavefront/client/src/types/tool.ts
  • wavefront/client/src/types/tts-config.ts
  • wavefront/client/src/types/voice-agent.ts
  • wavefront/client/src/types/workflow.ts
  • wavefront/client/src/utils/form-validation.ts
  • wavefront/client/src/utils/regex.ts
  • wavefront/client/src/utils/scroll.ts
  • wavefront/client/src/utils/string-formatting.ts
  • wavefront/client/vite.config.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vizsatiz vizsatiz merged commit c4805cd into develop Dec 13, 2025
7 of 8 checks passed
@vizsatiz vizsatiz deleted the feat/setup-workspace branch December 13, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants