[histv7] WIP: Fitting for RHist by claireguyot · Pull Request #6103 · root-project/root

claireguyot · 2020-07-30T13:15:58Z

Changes are not yet functional. I did my best at finishing all I could, but there are still some errors I couldn't correct in time. Because of these errors, I also wasn't able to test the changes with the fit.cxx file.

…tation.

… are yet not implemented.

…ild without errors because of incorrect dependencies.

…n interface RFitInterface.hxx. The project builds without error.

…n working because of templates. Compiling throws an error.

…templates, declaration and definition of some functions are now in the header RFitImpl.hxx. Compiling still throws some errors.

phsft-bot · 2020-07-30T13:16:10Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-07-30T13:21:28Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-07-30T13:19:46.649Z] FAILED: hist/histv7/test/CMakeFiles/histhistv7testUnit.dir/fit.cxx.o
[2020-07-30T13:19:46.915Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:106:18: error: no match for call to ‘(TF1) (ROOT::Experimental::Detail::RHistBinRef<ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1, double, std::vector<double>, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty> > >&)’
[2020-07-30T13:19:46.916Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:113:13: error: no matching function for call to ‘ROOT::Fit::BinData::Add(ROOT::Experimental::Detail::RHistBinRef<ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1, double, std::vector<double>, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty> > >::CoordArray_t, double)’
[2020-07-30T13:19:46.916Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:116:35: error: cannot bind non-const lvalue reference of type ‘double&’ to an rvalue of type ‘double’
[2020-07-30T13:19:46.916Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:118:13: error: no matching function for call to ‘ROOT::Fit::BinData::Add(ROOT::Experimental::Detail::RHistBinRef<ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1, double, std::vector<double>, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty> > >::CoordArray_t, double, double)’
[2020-07-30T13:19:46.916Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:173:26: error: no matching function for call to ‘BinContentToBinData(ROOT::Experimental::RHist<1, double, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty>&, std::shared_ptr<ROOT::Fit::BinData>&, TF1*&, ROOT::Fit::DataOptions&, ROOT::Fit::DataRange&)’

Warnings:

[2020-07-30T13:19:46.915Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/test/fit.cxx:25:14: warning: variable ‘chi2ref’ set but not used [-Wunused-but-set-variable]
[2020-07-30T13:19:46.917Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/test/fit.cxx:78:4: warning: control reaches end of non-void function [-Wreturn-type]

phsft-bot · 2020-07-30T13:36:58Z

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-07-30T13:36:07.542Z] FAILED: hist/histv7/test/CMakeFiles/histhistv7testUnit.dir/fit.cxx.o
[2020-07-30T13:36:08.133Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:106:13: error: no matching function for call to object of type 'TF1'
[2020-07-30T13:36:08.428Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:113:21: error: no matching member function for call to 'Add'
[2020-07-30T13:36:08.428Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:173:7: error: no matching function for call to 'BinContentToBinData'

Warnings:

[2020-07-30T13:36:08.133Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/hist/histv7/test/fit.cxx:78:4: warning: control may reach end of non-void lambda [-Wreturn-type]

phsft-bot · 2020-07-30T14:04:35Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-07-30T14:02:44.253Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(106,1): error C2664: 'Double_t TF1::operator ()(Double_t,Double_t,Double_t,Double_t) const': cannot convert argument 1 from 'ROOT::Experimental::Detail::RHistBinRef<HISTIMPL>' to 'Double_t' [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
[2020-07-30T14:02:44.253Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(106,1): error C2664: with [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
[2020-07-30T14:02:44.253Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(106,1): error C2664: [ [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
[2020-07-30T14:02:44.253Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(106,1): error C2664: HISTIMPL=ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1,double,std::vector<double,std::allocator<double>>,ROOT::Experimental::RHistStatContent,ROOT::Experimental::RHistStatUncertainty>> [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
[2020-07-30T14:02:44.253Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(106,1): error C2664: ] [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
[2020-07-30T14:02:44.254Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(113,1): error C2664: 'void ROOT::Fit::BinData::Add(const double *,double,const double *,double,double)': cannot convert argument 1 from 'ROOT::Experimental::Hist::RCoordArray<1>' to 'double' [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
[2020-07-30T14:02:44.254Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(116,1): error C2664: 'bool ROOT::Experimental::RFit::AdjustError(const ROOT::Fit::DataOptions &,double &,double)': cannot convert argument 2 from 'double' to 'double &' [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
[2020-07-30T14:02:44.254Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(118,1): error C2664: 'void ROOT::Fit::BinData::Add(const double *,double,const double *,double,double)': cannot convert argument 1 from 'ROOT::Experimental::Hist::RCoordArray<1>' to 'double' [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]

phsft-bot · 2020-07-30T14:06:39Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-4.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

projectroot.roottest.python.JupyROOT.roottest_python_JupyROOT_thread_local_notebook

phsft-bot · 2020-07-31T11:53:16Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-07-31T11:52:13.880Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:106:18: error: no match for call to ‘(TF1) (ROOT::Experimental::Detail::RHistBinRef<ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1, double, std::vector<double>, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty> > >&)’
[2020-07-31T11:52:13.880Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:113:13: error: no matching function for call to ‘ROOT::Fit::BinData::Add(ROOT::Experimental::Detail::RHistBinRef<ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1, double, std::vector<double>, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty> > >::CoordArray_t, double)’
[2020-07-31T11:52:13.880Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:116:35: error: cannot bind non-const lvalue reference of type ‘double&’ to an rvalue of type ‘double’
[2020-07-31T11:52:13.880Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:118:13: error: no matching function for call to ‘ROOT::Fit::BinData::Add(ROOT::Experimental::Detail::RHistBinRef<ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1, double, std::vector<double>, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty> > >::CoordArray_t, double, double)’
[2020-07-31T11:52:13.881Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:173:26: error: no matching function for call to ‘BinContentToBinData(ROOT::Experimental::RHist<1, double, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty>&, std::shared_ptr<ROOT::Fit::BinData>&, TF1*&, ROOT::Fit::DataOptions&, ROOT::Fit::DataRange&)’

Warnings:

[2020-07-31T11:52:13.880Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/test/fit.cxx:25:14: warning: variable ‘chi2ref’ set but not used [-Wunused-but-set-variable]
[2020-07-31T11:52:13.881Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/test/fit.cxx:78:4: warning: control reaches end of non-void function [-Wreturn-type]

ferdymercury · 2025-04-01T07:19:05Z

Closing due to #18191

claireguyot added 6 commits June 18, 2020 17:40

NFC: The members of DataOptions have their description in the documen…

85a8658

…tation.

[histv7] RHist::Fit is adapted from TH1::Fit, tests and factorisation…

5d58cb9

… are yet not implemented.

[histv7] WIP: Implementation in progress, the current code doesn't bu…

2496ff9

…ild without errors because of incorrect dependencies.

[histv7] Fit function is implemented in RFitImpl.hxx and usable via a…

3a7c1ae

…n interface RFitInterface.hxx. The project builds without error.

[histv7] The interface to access fitting functions is complete but no…

937f104

…n working because of templates. Compiling throws an error.

[histv7] Rework of the interface to access fitting functions. Due to …

e652292

…templates, declaration and definition of some functions are now in the header RFitImpl.hxx. Compiling still throws some errors.

claireguyot requested review from Axel-Naumann and HadrienG2 July 30, 2020 13:15

claireguyot assigned Axel-Naumann Jul 30, 2020

ferdymercury added the in:Hist label Apr 15, 2024

ferdymercury unassigned Axel-Naumann Apr 26, 2024

couet assigned lmoneta Sep 9, 2024

ferdymercury closed this Apr 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[histv7] WIP: Fitting for RHist#6103

[histv7] WIP: Fitting for RHist#6103
claireguyot wants to merge 6 commits intoroot-project:masterfrom
claireguyot:v7_hist_fitting

claireguyot commented Jul 30, 2020

Uh oh!

phsft-bot commented Jul 30, 2020

Uh oh!

phsft-bot commented Jul 30, 2020

Uh oh!

phsft-bot commented Jul 30, 2020

Uh oh!

phsft-bot commented Jul 30, 2020

Uh oh!

phsft-bot commented Jul 30, 2020

Uh oh!

phsft-bot commented Jul 31, 2020

Uh oh!

ferdymercury commented Apr 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

claireguyot commented Jul 30, 2020

Uh oh!

phsft-bot commented Jul 30, 2020

Uh oh!

phsft-bot commented Jul 30, 2020

Errors:

Warnings:

Uh oh!

phsft-bot commented Jul 30, 2020

Errors:

Warnings:

Uh oh!

phsft-bot commented Jul 30, 2020

Errors:

Uh oh!

phsft-bot commented Jul 30, 2020

Failing tests:

Uh oh!

phsft-bot commented Jul 31, 2020

Errors:

Warnings:

Uh oh!

ferdymercury commented Apr 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants