Don't overwrite the ExternalSemaSource in the modules case. #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modules implementation provides it's own sema source and overwriting this confuses clang when we have -fmodules enabled.
Contributor
|
@phsft-bot build! |
|
Starting build on |
vgvassilev
pushed a commit
to vgvassilev/root
that referenced
this pull request
Jun 12, 2017
…ject#538) The modules implementation provides it's own sema source and overwriting this confuses clang when we have -fmodules enabled.
vgvassilev
pushed a commit
to vgvassilev/root
that referenced
this pull request
Jun 12, 2017
…ject#538) The modules implementation provides it's own sema source and overwriting this confuses clang when we have -fmodules enabled.
Teemperor
added a commit
to Teemperor/root
that referenced
this pull request
Jun 13, 2017
…ject#538) The modules implementation provides it's own sema source and overwriting this confuses clang when we have -fmodules enabled.
vgvassilev
pushed a commit
that referenced
this pull request
Jun 13, 2017
The modules implementation provides it's own sema source and overwriting this confuses clang when we have -fmodules enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modules implementation provides it's own sema source and
overwriting this confuses clang when we have -fmodules enabled.