Made cassert a textual header. #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teemperor
force-pushed
the
MakeCassertTextual
branch
2 times, most recently
from
904857b to
fd7d5f3
Compare
|
Starting build on |
Teemperor
force-pushed
the
MakeCassertTextual
branch
from
fd7d5f3 to
81c6b21
Compare
|
Starting build on |
It's AST supposed to depend on NDEBUG, so having this as a module is wrong. And we just remove cassert instead of making it textual to be consistent with the OS X system modulemap.
vgvassilev
pushed a commit
to vgvassilev/root
that referenced
this pull request
Jun 12, 2017
…ot-project#537) It's AST supposed to depend on NDEBUG, so having this as a module is wrong. And we just remove cassert instead of making it textual to be consistent with the OS X system modulemap.
vgvassilev
pushed a commit
to vgvassilev/root
that referenced
this pull request
Jun 12, 2017
…ot-project#537) It's AST supposed to depend on NDEBUG, so having this as a module is wrong. And we just remove cassert instead of making it textual to be consistent with the OS X system modulemap.
Teemperor
added a commit
to Teemperor/root
that referenced
this pull request
Jun 13, 2017
…ot-project#537) It's AST supposed to depend on NDEBUG, so having this as a module is wrong. And we just remove cassert instead of making it textual to be consistent with the OS X system modulemap.
vgvassilev
pushed a commit
that referenced
this pull request
Jun 13, 2017
It's AST supposed to depend on NDEBUG, so having this as a module is wrong. And we just remove cassert instead of making it textual to be consistent with the OS X system modulemap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's AST supposed to depend on NDEBUG, so having this as a module is
wrong.