Skip to content

Conversation

yamaguchi1024
Copy link
Contributor

Ideally we could stop generating rdict when runtime_cxxmodules is ON, like:

if (!hasCxxModules && gDriverConfig->fInitializeStreamerInfoROOTFile) {
   gDriverConfig->fInitializeStreamerInfoROOTFile(modGen.GetModuleFileName().c_str());
}

but doing that caused many errors in dictionary generation. So
apparently we can't do that. Instead, we can stop loading them at
runtime which gives around 1MB of improvement in memory.

@phsft-bot
Copy link

Starting build on slc6/gcc48, slc6/gcc62, slc6-i686/gcc49, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

@phsft-bot
Copy link

@phsft-bot
Copy link

@phsft-bot
Copy link

Build failed on centos7/gcc7.
See console output.

Warnings:

  • ../root/core/newdelete/src/NewDelete.cxx:217:11: warning: ‘operator new’ must not return NULL unless it is declared ‘throw()’ (or -fcheck-new is in effect)
  • ../root/core/newdelete/src/NewDelete.cxx:344:11: warning: ‘operator new’ must not return NULL unless it is declared ‘throw()’ (or -fcheck-new is in effect)
  • ../root/core/newdelete/src/NewDelete.cxx:263:6: warning: the program should also define ‘void operator delete(void*, std::size_t)’ [-Wsized-deallocation]
  • ../root/core/newdelete/src/NewDelete.cxx:367:6: warning: the program should also define ‘void operator delete [](void*, std::size_t)’ [-Wsized-deallocation]
  • ../root/graf3d/eve7/glu/render.c:238:71: warning: unused parameter ‘size’ [-Wunused-parameter]

Failing tests:

@phsft-bot
Copy link

Build failed on centos7/gcc62.
See console output.

Warnings:

  • ../root/graf3d/eve7/glu/render.c:238:71: warning: unused parameter ‘size’ [-Wunused-parameter]

Failing tests:

@phsft-bot
Copy link

@phsft-bot
Copy link

Build failed on fedora28/native.
See console output.

Warnings:

  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:309:11: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<void*, long unsigned int>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:296:13: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<clang::CXXRecordDecl*, clang::SourceLocation>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:296:13: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<const clang::CXXMethodDecl*, const clang::CXXMethodDecl*>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:296:13: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<clang::CXXMethodDecl*, const clang::FunctionProtoType*>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:309:11: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<void*, long unsigned int>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:309:11: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<void*, long unsigned int>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:309:11: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<void*, long unsigned int>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:309:11: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<void*, long unsigned int>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:296:13: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<clang::CXXRecordDecl*, clang::SourceLocation>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:296:13: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<const clang::CXXMethodDecl*, const clang::CXXMethodDecl*>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]

And 65 more

Failing tests:

@phsft-bot
Copy link

Build failed on mac1013/native.
See console output.

Warnings:

  • ld: warning: text-based stub file /System/Library/Frameworks//OpenGL.framework/OpenGL.tbd and library file /System/Library/Frameworks//OpenGL.framework/OpenGL are out of sync. Falling back to library file for linking.
  • ld: warning: text-based stub file /System/Library/Frameworks//OpenGL.framework/OpenGL.tbd and library file /System/Library/Frameworks//OpenGL.framework/OpenGL are out of sync. Falling back to library file for linking.
  • ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib are out of sync. Falling back to library file for linking.
  • ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib are out of sync. Falling back to library file for linking.
  • ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
  • ld: warning: text-based stub file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit.tbd and library file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit are out of sync. Falling back to library file for linking.
  • ld: warning: text-based stub file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation.tbd and library file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation are out of sync. Falling back to library file for linking.
  • ld: warning: text-based stub file /System/Library/Frameworks//ApplicationServices.framework/Versions/A/ApplicationServices.tbd and library file /System/Library/Frameworks//ApplicationServices.framework/Versions/A/ApplicationServices are out of sync. Falling back to library file for linking.
  • ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation are out of sync. Falling back to library file for linking.
  • ld: warning: text-based stub file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics.tbd and library file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics are out of sync. Falling back to library file for linking.

And 77 more

Failing tests:

@yamaguchi1024
Copy link
Contributor Author

@phsft-bot build

@phsft-bot
Copy link

Starting build on slc6/gcc48, slc6/gcc62, slc6-i686/gcc49, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

@yamaguchi1024
Copy link
Contributor Author

@phsft-bot build

@phsft-bot
Copy link

Starting build on ROOT-centos7/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -Dccache=ON
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-centos7/noimt.
See console output.

Errors:

  • collect2: error: ld returned 1 exit status
  • error: unable to read PCH file /mnt/build/jenkins/workspace/root-pullrequests-build/build/etc/allDict.cxx.pch: 'No such file or directory'

@phsft-bot
Copy link

Starting build on ROOT-centos7/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -Dccache=ON
How to customize builds

@phsft-bot
Copy link

Build failed on mac1014/cxx17.
See console output.

Ideally we could stop generating rdict when runtime_cxxmodules is ON, like:
```
if (!hasCxxModules && gDriverConfig->fInitializeStreamerInfoROOTFile) {
   gDriverConfig->fInitializeStreamerInfoROOTFile(modGen.GetModuleFileName().c_str());
}
```
but doing that caused many errors in dictionary generation. So
apparently we can't do that. Instead, we can stop loading them at
runtime which gives around 1MB of improvement in memory.
@phsft-bot
Copy link

Build failed on ROOT-centos7/noimt.
See console output.

Errors:

  • collect2: error: ld returned 1 exit status
  • error: unable to read PCH file /mnt/build/jenkins/workspace/root-pullrequests-build/build/etc/allDict.cxx.pch: 'No such file or directory'

Co-Authored-By: yamaguchi1024 <yukatkh@gmail.com>
@phsft-bot
Copy link

Starting build on ROOT-centos7/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -Dccache=ON
How to customize builds

@phsft-bot
Copy link

Build failed on mac1014/cxx17.
See console output.

@phsft-bot
Copy link

Build failed on ROOT-centos7/noimt.
See console output.

Errors:

  • collect2: error: ld returned 1 exit status
  • error: unable to read PCH file /mnt/build/jenkins/workspace/root-pullrequests-build/build/etc/allDict.cxx.pch: 'No such file or directory'

@vgvassilev
Copy link
Member

Superseded by #3012.

@vgvassilev vgvassilev closed this Nov 22, 2018
@yamaguchi1024 yamaguchi1024 deleted the rdict branch February 20, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants