-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[cxxmodules] Don't load rdict for cxxmodules #2912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Starting build on |
Build failed on ubuntu16/native. Failing tests: |
Build failed on slc6-i686/gcc49. Failing tests: |
Build failed on centos7/gcc7. Warnings:
Failing tests: |
Build failed on centos7/gcc62. Warnings:
Failing tests: |
Build failed on slc6/gcc48. Failing tests: |
Build failed on fedora28/native. Warnings:
And 65 more Failing tests: |
Build failed on mac1013/native. Warnings:
And 77 more Failing tests: |
@phsft-bot build |
Starting build on |
@phsft-bot build |
Starting build on |
Build failed on ROOT-centos7/noimt. Errors:
|
Starting build on |
Build failed on mac1014/cxx17. |
Ideally we could stop generating rdict when runtime_cxxmodules is ON, like: ``` if (!hasCxxModules && gDriverConfig->fInitializeStreamerInfoROOTFile) { gDriverConfig->fInitializeStreamerInfoROOTFile(modGen.GetModuleFileName().c_str()); } ``` but doing that caused many errors in dictionary generation. So apparently we can't do that. Instead, we can stop loading them at runtime which gives around 1MB of improvement in memory.
Build failed on ROOT-centos7/noimt. Errors:
|
Co-Authored-By: yamaguchi1024 <yukatkh@gmail.com>
Starting build on |
Build failed on mac1014/cxx17. |
Build failed on ROOT-centos7/noimt. Errors:
|
Superseded by #3012. |
Ideally we could stop generating rdict when runtime_cxxmodules is ON, like:
but doing that caused many errors in dictionary generation. So
apparently we can't do that. Instead, we can stop loading them at
runtime which gives around 1MB of improvement in memory.