[cxxmodules] Don't load rdict for cxxmodules #2912

yamaguchi1024 · 2018-11-02T14:41:34Z

Ideally we could stop generating rdict when runtime_cxxmodules is ON, like:

if (!hasCxxModules && gDriverConfig->fInitializeStreamerInfoROOTFile) {
   gDriverConfig->fInitializeStreamerInfoROOTFile(modGen.GetModuleFileName().c_str());
}

but doing that caused many errors in dictionary generation. So
apparently we can't do that. Instead, we can stop loading them at
runtime which gives around 1MB of improvement in memory.

phsft-bot · 2018-11-02T14:41:43Z

Starting build on slc6/gcc48, slc6/gcc62, slc6-i686/gcc49, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

phsft-bot · 2018-11-02T15:03:31Z

Build failed on ubuntu16/native.
See console output.

Failing tests:

projectroot.roottest.root.io.treeForeign.roottest_root_io_treeForeign_testForeignDraw

phsft-bot · 2018-11-02T15:09:34Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

And 8 more

phsft-bot · 2018-11-02T15:28:28Z

Build failed on slc6-i686/gcc49.
See console output.

Failing tests:

projectroot.roottest.root.io.treeForeign.roottest_root_io_treeForeign_testForeignDraw

phsft-bot · 2018-11-02T15:30:59Z

Build failed on centos7/gcc7.
See console output.

Warnings:

../root/core/newdelete/src/NewDelete.cxx:217:11: warning: ‘operator new’ must not return NULL unless it is declared ‘throw()’ (or -fcheck-new is in effect)
../root/core/newdelete/src/NewDelete.cxx:344:11: warning: ‘operator new’ must not return NULL unless it is declared ‘throw()’ (or -fcheck-new is in effect)
../root/core/newdelete/src/NewDelete.cxx:263:6: warning: the program should also define ‘void operator delete(void*, std::size_t)’ [-Wsized-deallocation]
../root/core/newdelete/src/NewDelete.cxx:367:6: warning: the program should also define ‘void operator delete [](void*, std::size_t)’ [-Wsized-deallocation]
../root/graf3d/eve7/glu/render.c:238:71: warning: unused parameter ‘size’ [-Wunused-parameter]

Failing tests:

projectroot.roottest.root.io.treeForeign.roottest_root_io_treeForeign_testForeignDraw

phsft-bot · 2018-11-02T15:37:42Z

Build failed on centos7/gcc62.
See console output.

Warnings:

../root/graf3d/eve7/glu/render.c:238:71: warning: unused parameter ‘size’ [-Wunused-parameter]

Failing tests:

projectroot.roottest.root.io.treeForeign.roottest_root_io_treeForeign_testForeignDraw

phsft-bot · 2018-11-02T15:51:15Z

Build failed on slc6/gcc48.
See console output.

Failing tests:

projectroot.roottest.root.io.treeForeign.roottest_root_io_treeForeign_testForeignDraw

phsft-bot · 2018-11-02T15:51:48Z

Build failed on fedora28/native.
See console output.

Warnings:

/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:309:11: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<void*, long unsigned int>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:296:13: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<clang::CXXRecordDecl*, clang::SourceLocation>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:296:13: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<const clang::CXXMethodDecl*, const clang::CXXMethodDecl*>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:296:13: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<clang::CXXMethodDecl*, const clang::FunctionProtoType*>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:309:11: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<void*, long unsigned int>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:309:11: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<void*, long unsigned int>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:309:11: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<void*, long unsigned int>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:309:11: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<void*, long unsigned int>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:296:13: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<clang::CXXRecordDecl*, clang::SourceLocation>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include/llvm/ADT/SmallVector.h:296:13: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct std::pair<const clang::CXXMethodDecl*, const clang::CXXMethodDecl*>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]

And 65 more

Failing tests:

projectroot.roottest.root.io.treeForeign.roottest_root_io_treeForeign_testForeignDraw

phsft-bot · 2018-11-02T16:58:16Z

Build failed on mac1013/native.
See console output.

Warnings:

ld: warning: text-based stub file /System/Library/Frameworks//OpenGL.framework/OpenGL.tbd and library file /System/Library/Frameworks//OpenGL.framework/OpenGL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenGL.framework/OpenGL.tbd and library file /System/Library/Frameworks//OpenGL.framework/OpenGL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit.tbd and library file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation.tbd and library file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ApplicationServices.framework/Versions/A/ApplicationServices.tbd and library file /System/Library/Frameworks//ApplicationServices.framework/Versions/A/ApplicationServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics.tbd and library file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics are out of sync. Falling back to library file for linking.

And 77 more

Failing tests:

projectroot.roottest.root.io.treeForeign.roottest_root_io_treeForeign_testForeignDraw

yamaguchi1024 · 2018-11-05T12:23:50Z

@phsft-bot build

phsft-bot · 2018-11-05T12:23:57Z

Starting build on slc6/gcc48, slc6/gcc62, slc6-i686/gcc49, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

phsft-bot · 2018-11-05T12:50:21Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

And 8 more

yamaguchi1024 · 2018-11-20T10:13:27Z

@phsft-bot build

phsft-bot · 2018-11-20T10:13:36Z

Starting build on ROOT-centos7/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -Dccache=ON
How to customize builds

phsft-bot · 2018-11-20T13:08:10Z

Build failed on ROOT-centos7/noimt.
See console output.

Errors:

collect2: error: ld returned 1 exit status
error: unable to read PCH file /mnt/build/jenkins/workspace/root-pullrequests-build/build/etc/allDict.cxx.pch: 'No such file or directory'

phsft-bot · 2018-11-20T19:11:40Z

Starting build on ROOT-centos7/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -Dccache=ON
How to customize builds

phsft-bot · 2018-11-20T19:11:58Z

Build failed on mac1014/cxx17.
See console output.

Ideally we could stop generating rdict when runtime_cxxmodules is ON, like: ``` if (!hasCxxModules && gDriverConfig->fInitializeStreamerInfoROOTFile) { gDriverConfig->fInitializeStreamerInfoROOTFile(modGen.GetModuleFileName().c_str()); } ``` but doing that caused many errors in dictionary generation. So apparently we can't do that. Instead, we can stop loading them at runtime which gives around 1MB of improvement in memory.

phsft-bot · 2018-11-20T19:23:13Z

Build failed on ROOT-centos7/noimt.
See console output.

Errors:

collect2: error: ld returned 1 exit status
error: unable to read PCH file /mnt/build/jenkins/workspace/root-pullrequests-build/build/etc/allDict.cxx.pch: 'No such file or directory'

core/metacling/src/TCling.cxx

Co-Authored-By: yamaguchi1024 <yukatkh@gmail.com>

phsft-bot · 2018-11-21T09:26:21Z

Starting build on ROOT-centos7/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -Dccache=ON
How to customize builds

phsft-bot · 2018-11-21T09:26:40Z

Build failed on mac1014/cxx17.
See console output.

phsft-bot · 2018-11-21T09:36:45Z

Build failed on ROOT-centos7/noimt.
See console output.

Errors:

collect2: error: ld returned 1 exit status
error: unable to read PCH file /mnt/build/jenkins/workspace/root-pullrequests-build/build/etc/allDict.cxx.pch: 'No such file or directory'

vgvassilev · 2018-11-22T07:34:20Z

Superseded by #3012.

yamaguchi1024 requested review from pcanal and vgvassilev November 2, 2018 14:41

yamaguchi1024 mentioned this pull request Nov 2, 2018

[cxxmodules] Add support for ACLiC with cxxmodules #2396

Merged

oshadura assigned vgvassilev Nov 8, 2018

vgvassilev mentioned this pull request Nov 20, 2018

[cxxmodules] Do not generate rdict files if we have a module. #3012

Closed

yamaguchi1024 force-pushed the rdict branch from a86b6af to e23d611 Compare November 20, 2018 19:11

vgvassilev reviewed Nov 21, 2018

View reviewed changes

core/metacling/src/TCling.cxx Outdated Show resolved Hide resolved

Update core/metacling/src/TCling.cxx

00cb21f

Co-Authored-By: yamaguchi1024 <yukatkh@gmail.com>

vgvassilev closed this Nov 22, 2018

yamaguchi1024 deleted the rdict branch February 20, 2019 17:21

[cxxmodules] Don't load rdict for cxxmodules #2912

[cxxmodules] Don't load rdict for cxxmodules #2912

Uh oh!

Conversation

yamaguchi1024 commented Nov 2, 2018

Uh oh!

phsft-bot commented Nov 2, 2018

Uh oh!

phsft-bot commented Nov 2, 2018

Failing tests:

Uh oh!

phsft-bot commented Nov 2, 2018

Failing tests:

Uh oh!

phsft-bot commented Nov 2, 2018

Failing tests:

Uh oh!

phsft-bot commented Nov 2, 2018

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Nov 2, 2018

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Nov 2, 2018

Failing tests:

Uh oh!

phsft-bot commented Nov 2, 2018

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Nov 2, 2018

Warnings:

Failing tests:

Uh oh!

yamaguchi1024 commented Nov 5, 2018

Uh oh!

phsft-bot commented Nov 5, 2018

Uh oh!

phsft-bot commented Nov 5, 2018

Failing tests:

Uh oh!

yamaguchi1024 commented Nov 20, 2018

Uh oh!

phsft-bot commented Nov 20, 2018

Uh oh!

phsft-bot commented Nov 20, 2018

Errors:

Uh oh!

phsft-bot commented Nov 20, 2018

Uh oh!

phsft-bot commented Nov 20, 2018

Uh oh!

phsft-bot commented Nov 20, 2018

Errors:

Uh oh!

Uh oh!

phsft-bot commented Nov 21, 2018

Uh oh!

phsft-bot commented Nov 21, 2018

Uh oh!

phsft-bot commented Nov 21, 2018

Errors:

Uh oh!

vgvassilev commented Nov 22, 2018

Uh oh!

Uh oh!