Draft
Conversation
Idea to have interface which handle painting of many segments at once. On platforms like X11 drawing of many lines at once can be performed with single call
Apply clip condition, draw on virtualx and virtualps
Here no clipping is required, for VirtualPS coordinates need to be recalculated
Make lambda to paint ticks at specified index/position So reduce code duplication when painting extra ticks on left and right sides. Prepare code to fill buffers for segments painting
First collect all ticks and grids positions in the vector and then call function at the end
In SVG files all grids lines drawn together after all ticks so order is changed. But produced image will not change while grids always drawn on the top of the ticks PS image can reduce in size while now attributes not switched between ticks and grids all the time
Provide default implementation to ensure that all possible derived classes will work with new code
So first recalculate/clip buffers and then call methods
Test Results 22 files 22 suites 3d 7h 2m 50s ⏱️ For more details on these failures, see this check. Results for commit bb1c142. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce methods to provide meaningful access to X11 XDrawSegments functionality
This should reduce total number of X11 calls and improve performance of slow remote X11 displays
But for that one really need to use such functionality in the code
As first exercise try to modify TGaxis painter where many ticks drawn with separate calls.
Instead collect all them together and call DrawSegments at the end.