[tmva][sofie] Add support for parsing onnx::Add operator in PyTorch parser#21398
Open
MrViiV wants to merge 2 commits intoroot-project:masterfrom
Open
[tmva][sofie] Add support for parsing onnx::Add operator in PyTorch parser#21398MrViiV wants to merge 2 commits intoroot-project:masterfrom
MrViiV wants to merge 2 commits intoroot-project:masterfrom
Conversation
Author
|
@lmoneta @sanjibansg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
This PR adds support for parsing the
onnx::Addoperator in the SOFIE PyTorch parser (RModelParser_PyTorch.cxx).The Add operator is a fundamental element-wise tensor operation and is widely used in modern neural network architectures, including residual connections (e.g. ResNet), transformer blocks, and other composite models exported from PyTorch.
Specifically, this PR:
MakePyTorchAddfunction to prepare the correspondingROperator_BasicBinarywithEBasicBinaryOperator::Add"onnx::Add"operator in the PyTorch parser operator mapThis improves the PyTorch parser’s compatibility with real-world exported ONNX models.
Checklist:
Testing:
A minimal PyTorch model containing an Add operation was exported to ONNX and verified to produce an
onnx::Addnode compatible with this parser extension.