Skip to content

Skip the failing h2root test on mac beta.#21391

Open
hageboeck wants to merge 2 commits intoroot-project:masterfrom
hageboeck:mac-beta-failures
Open

Skip the failing h2root test on mac beta.#21391
hageboeck wants to merge 2 commits intoroot-project:masterfrom
hageboeck:mac-beta-failures

Conversation

@hageboeck
Copy link
Member

This will mask the test failure on mac beta until it's resolved or disabled.

  • Run the test in a subprocess. This allows for checking its output and exit status, as system-level failures of the parent always lead to a failure.
  • Skip the test if the known error is encountered.
  • Set the WILL_FAIL property. If the test passes unexpectedly, it will signal this with a failure.

Running h2root in a subprocess will allow for marking the test as
WILL_FAIL in CTest. If it's not running as a subprocess, the WILL_FAIL
has no effect, since it checks the exit status.
@hageboeck hageboeck self-assigned this Feb 26, 2026
@hageboeck hageboeck marked this pull request as ready for review February 26, 2026 09:39
@hageboeck hageboeck requested a review from bellenot as a code owner February 26, 2026 09:39
- If the known error message is encountered, the test will be skipped.
- If the test passes unexpectedly, the WILL_FAIL will signal this.
@github-actions
Copy link

Test Results

    22 files      22 suites   3d 3h 34m 51s ⏱️
 3 804 tests  3 802 ✅  1 💤 1 ❌
75 638 runs  75 627 ✅ 10 💤 1 ❌

For more details on these failures, see this check.

Results for commit fc1dc8b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants