Skip the failing h2root test on mac beta.#21391
Open
hageboeck wants to merge 2 commits intoroot-project:masterfrom
Open
Skip the failing h2root test on mac beta.#21391hageboeck wants to merge 2 commits intoroot-project:masterfrom
hageboeck wants to merge 2 commits intoroot-project:masterfrom
Conversation
Running h2root in a subprocess will allow for marking the test as WILL_FAIL in CTest. If it's not running as a subprocess, the WILL_FAIL has no effect, since it checks the exit status.
25c1835 to
d7131fb
Compare
- If the known error message is encountered, the test will be skipped. - If the test passes unexpectedly, the WILL_FAIL will signal this.
d7131fb to
fc1dc8b
Compare
dpiparo
approved these changes
Feb 26, 2026
Test Results 22 files 22 suites 3d 3h 34m 51s ⏱️ For more details on these failures, see this check. Results for commit fc1dc8b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will mask the test failure on mac beta until it's resolved or disabled.
WILL_FAILproperty. If the test passes unexpectedly, it will signal this with a failure.