[build] Align SDK path seen by rootcling with CMake#21390
Merged
vepadulano merged 1 commit intoroot-project:masterfrom Feb 26, 2026
Merged
[build] Align SDK path seen by rootcling with CMake#21390vepadulano merged 1 commit intoroot-project:masterfrom
vepadulano merged 1 commit intoroot-project:masterfrom
Conversation
vepadulano
added
clean build
vgvassilev
reviewed
Feb 26, 2026
The path to the SDK used by the build is stored within CMAKE_OSX_SYSROOT. The compiler invocations issued directly by the CMake generator will automatically inherit the SDKROOT variable to find the Apple SDK. But rootcling and similar other compiler-based utilities ROOT provides do not automatically see all CMake variables. When the Apple SDK is not found in standard locations, e.g. during a conda build for conda-forge, rootcling is not able to find the SDK automatically. This commit proposes to inject the SDK path from CMake to rootcling by aligning SDKROOT environment variable with the value of CMAKE_OSX_SYSROOT. This is an upstream of https://github.com/conda-forge/root-feedstock/blob/df86316b299d8214d3181d76c31925696f076d5e/recipe/patches/0014-Force-SDKROOT.patch
vepadulano
force-pushed
the
rootcling-force-sdkroot
branch
from
1e5a932 to
b44b5f3
Compare
Test Results 22 files 22 suites 3d 3h 11m 6s ⏱️ For more details on these failures, see this check. Results for commit b44b5f3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path to the SDK used by the build is stored within CMAKE_OSX_SYSROOT. The compiler invocations issued directly by the CMake generator will automatically inherit the SDKROOT variable to find the Apple SDK. But rootcling and similar other compiler-based utilities ROOT provides do not automatically see all CMake variables. When the Apple SDK is not found in standard locations, e.g. during a conda build for conda-forge, rootcling is not able to find the SDK automatically. This commit proposes to inject the SDK path from CMake to rootcling by aligning SDKROOT environment variable with the value of CMAKE_OSX_SYSROOT.
This is an upstream of https://github.com/conda-forge/root-feedstock/blob/df86316b299d8214d3181d76c31925696f076d5e/recipe/patches/0014-Force-SDKROOT.patch