[build] Allow searching for external FreeType on MacOS#21389
Open
vepadulano wants to merge 1 commit intoroot-project:masterfrom
Open
[build] Allow searching for external FreeType on MacOS#21389vepadulano wants to merge 1 commit intoroot-project:masterfrom
vepadulano wants to merge 1 commit intoroot-project:masterfrom
Conversation
vepadulano
added
in:Build System
clean build
And fallback to using the builtin if the external can't be found. Useful when there is an externally-provided FreeType library on MacOS, such as on conda-forge. This is an upstream of https://github.com/conda-forge/root-feedstock/blob/df86316b299d8214d3181d76c31925696f076d5e/recipe/patches/0009-disable-builtin-freetype-macos.patch
vepadulano
force-pushed
the
apple-do-not-force-builtin-freetype
branch
from
018844b to
0faedfd
Compare
Test Results 22 files 22 suites 3d 7h 22m 36s ⏱️ For more details on these failures, see this check. Results for commit 0faedfd. |
Contributor
|
Great! This change actually shows that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fallback to using the builtin if the external can't be found.
Useful when there is an externally-provided FreeType library on MacOS, such as on conda-forge.
This is an upstream of https://github.com/conda-forge/root-feedstock/blob/df86316b299d8214d3181d76c31925696f076d5e/recipe/patches/0014-Force-SDKROOT.patch