[tree] Resolve name truncation issues in TTree::Scan#21383
Draft
al-025 wants to merge 3 commits intoroot-project:masterfrom
Draft
[tree] Resolve name truncation issues in TTree::Scan#21383al-025 wants to merge 3 commits intoroot-project:masterfrom
al-025 wants to merge 3 commits intoroot-project:masterfrom
Conversation
silverweed
reviewed
Feb 26, 2026
Test Results 22 files 22 suites 3d 6h 23m 41s ⏱️ For more details on these failures, see this check. Results for commit 02410bc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #6473
As described in the linked issue, the small default column width for
TTree::Scancan lead to common truncations of column names. Since there was no indication that truncation had been performed, this could lead to some confusing output.This PR makes two changes:
colsizeis explicitly set then no resizing will be performed....to indicate truncation had been performed. If for some reason the column size is 3 or less, the first character of the column name will be retained and the remaining characters will be replaced with.s.Marking as draft for now - these changes will obviously cause lots of differences in tests that use
TTree::Scanas part of their output, should I be going through and updating all the reference files myself?