[rootcling] Remove llvm::cl dependency by using ROOT's optparse
#20903
+343
−254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would potentially remove issues like ``` CommandLine Error: Option 'W' registered more than once! ``` caused by `llvm::cl` registering the same options multiple times when ROOT is linked against a shared `libLLVM`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
This is a draft PR to test if it is possible to use optparse in rootcling:
bareclingsubcommand makes this slightly complicated, but not sure if it is worth adding subcommand feature to optparse.OptionParser.htoo, haven't looked into this.This would potentially remove issues like
caused by
llvm::clregistering the same options multiple times ROOT is linked against a sharedlibLLVM.Changes or fixes:
Checklist:
This PR fixes #