Address some minor TODOs after CINT to Cling migration #20757
Merged
+7
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
requested review from
bellenot,
couet,
lmoneta and
pcanal
as code owners
I also understand now that the `TGQuartz.h` header is actually needed by the ROOT plugin system.
guitargeek
force-pushed
the
cint_to_cling_followup
branch
from
b36a96e to
a56ac8d
Compare
guitargeek
changed the title
Test Results 21 files 21 suites 4d 4h 37m 28s ⏱️ For more details on these failures, see this check. Results for commit a56ac8d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on the observations made in #20694.
I also understand now that the
TGQuartz.hheader is actually needed by the ROOT plugin system.