[reve] Improvements in camera control and frustum update. REveBoxSet correction. #20670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l udpates in frustrum front and back clip.
…ip optimization for perspective camera. * GlViewerRCore.js: - Add this.scene_bbox, add flag recalc_bbox to request_render() - Call camera.optimizNearFar(scene_bbox) for perspective camera - ApplyTemporaryRCoreExtensions() -- that is not used at this point * EveScene.js - Add comment about better handling of scene / viewer bounding boxes. - In Scene::endChanges() call render via request_render and request bbox recalc.
Contributor
Author
|
@linev Please check. |
Test Results 21 files 21 suites 4d 1h 30m 21s ⏱️ For more details on these failures, see this check. Results for commit 039531d. |
dpiparo
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
This PR updates RenderCore version to 1.8 with following changes:
ctrl: *0.1, ctrl-shift: *0.01, shift: *10.0
This PR fixed issue reported in FireworksWeb alja/FireworksWeb#128, alja/FireworksWeb#131