io: Support 64 bits position/byte-count #20574
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 4d 2h 1m 49s ⏱️ For more details on these failures, see this check. Results for commit d7863e9. ♻️ This comment has been updated with latest results. |
pcanal
force-pushed
the
Arlesienne
branch
2 times, most recently
from
00fe0ac to
41a877a
Compare
In order to support 64 bits byte count, which does not fit in the space reverse for them in the stream (4 bytes minus 3 control bits) and the position and some byte count do not fit in the variable used in existing code (arguments to WriteVersion, SetByteCount, ReadVersion and CheckByteCount), we need to pass them indirectly. Since the streaming is inherently serial, we can leverage the sequence of calls and cache the 64 bits values in a queue. The bytecount that can not be stored in place in the stream will be held in a collection (fByteCounts) that need to be stored externally to the buffer.
Note to store and restore the larger than 1GB byte count use:
// Copy the content of the const reference.
auto bytecounts{b.GetByteCounts()};
...
b.SetByteCounts(std::move(bytecounts));
pcanal
requested review from
bellenot,
jblomer and
silverweed
and removed request for
bellenot
silverweed
reviewed
Dec 12, 2025
| tobuf(buf, cnt | kByteCountMask); | ||
|
|
||
| if (cnt >= kMaxMapCount) { | ||
| // NOTE: This should now be unreachable. |
Contributor
There was a problem hiding this comment.
Then maybe let's put an assert on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.