minicern fixes

[couet]

• Put PAWC and QUEST common blocks to have a unique centralised definition
• In kernlib.f: enlarge the size of the input string MT to be compatible with some calls.
• In zebra.f: use pawc.inc and quest.inc
• In hbook.f: use pawc.inc and quest.inc, fixes the output character strings called from C++

[ferdymercury]

Thanks a lot, I think this goes in the right direction,
but with these changes I still get crash on alma9 arm64 and mac14 if I remove the -O0 flag, which is a sign that there is something still fishy with the memory mapping C vs Fortran

See failure here: https://github.com/root-project/root/actions/runs/19748615052/job/56587668201?pr=20538
as well as https://github.com/root-project/root/actions/runs/19748615052/job/56587668122?pr=20538

   *** Break *** segmentation violation
   Generating stack trace...
   0x000000000040a7ec in hrfile_ at /github/home/ROOT-CI/src/misc/minicern/src/hbook.f:343 from h2root
   0x000000000040feb8 in hropen_ at /github/home/ROOT-CI/src/misc/minicern/src/hbook.f:268 from h2root
   0x0000000000404d70 in main at /github/home/ROOT-CI/src/main/src/h2root.cxx:333 from h2root
   0x0000ffff94cf8540 in <unknown> from /lib64/libc.so.6
   0x0000ffff94cf8618 in __libc_start_main at :? from /lib64/libc.so.6
   0x00000000004050b0 in _start + 0x30 from h2root


  -- BEGIN TEST OUTPUT --
   RZIODO. Error at record =    2 LUN =    10 IOSTAT =  5001
   >>>>>> CALL RZEND(CHDIR)
   Cannot open fileHROPEN           0
   Error on hropen was 101 
  Error cannot open input file: mb4i1.hbook

If you turn on address sanitizer on minicern/CMakeLists.txt it will show some warnings

[github-actions]

Test Results

    21 files      21 suites   3d 17h 50m 54s ⏱️
 3 777 tests  3 777 ✅ 0 💤 0 ❌
77 471 runs  77 471 ✅ 0 💤 0 ❌

Results for commit ea2885c.

[couet]

I can reproduce the crash on macphsft19.

[ferdymercury]

Maybe using https://cmake.org/cmake/help/latest/module/FortranCInterface.html, https://fortran-lang.discourse.group/t/cmake-fortrancinterface/7573 could help in simplifying the connection C - Fortran

[ferdymercury]

If I turn on Wall Wextra warnings via set_target_properties(minicern PROPERTIES COMPILE_FLAGS "-Wall -Wextra"), I see (https://github.com/root-project/root/actions/runs/20062341758/job/57542127199?pr=20538)

several warnings of the type:

 Warning: Array reference at (1) out of bounds (8729 > 8704) in loop beginning at (2) [-Wdo-subscript]
  /github/home/ROOT-CI/src/misc/minicern/src/zebra.f:574:45:

   /github/home/ROOT-CI/src/misc/minicern/src/hbook.f:2514:72:
  
   2514 |       BSLASH='\\'
        |                                                                        1
  Warning: CHARACTER expression will be truncated in assignment (1/2) at (1) [-Wcharacter-truncation]