Skip to content

[webcanvas] correctly use TF1::Save() #20432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
+10 −2
Merged

[webcanvas] correctly use TF1::Save() #20432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a0124f
[webcanv] fix storage of TF1 values
linev Nov 14, 2025
479975e
Adjust stressGraphics_web.ref file
linev Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion gui/webgui6/src/TWebCanvas.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#include "TList.h"
#include "TF1.h"
#include "TF2.h"
#include "TF3.h"
#include "TH1.h"
#include "TH2.h"
#include "THStack.h"
Expand Down Expand Up @@ -858,7 +859,14 @@ void TWebCanvas::CreatePadSnapshot(TPadWebSnapshot &paddata, TPad *pad, Long64_t
if ((fTF1UseSave == 1) && f1->HasSave())
return;

f1->Save(0, 0, 0, 0, 0, 0);
auto f3 = dynamic_cast<TF3 *>(f1);
auto f2 = dynamic_cast<TF2 *>(f1);
if (f3)
f3->Save(f3->GetXmin(), f3->GetXmax(), f3->GetYmin(), f3->GetYmax(), f3->GetZmin(), f3->GetZmax());
else if (f2)
f2->Save(f2->GetXmin(), f2->GetXmax(), f2->GetYmin(), f2->GetYmax(), 0, 0);
else
f1->Save(f1->GetXmin(), f1->GetXmax(), 0, 0, 0, 0);
};

auto create_stats = [&]() {
Expand Down
2 changes: 1 addition & 1 deletion test/stressGraphics_web.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
gmultierrors 4812 50 9590 200 51664 20000 27741 8000 4812 50
tmultigraph1 12629 52 20641 219 89532 21704 58976 13483 12600 80
tmultigraph2 33040 69 50688 694 125388 21334 98573 19359 32994 148
waves 1111600 100 3933582 50 248290 61958 298343 100544 1124318 700
waves 1124344 100 3981172 50 248290 61958 298343 100544 1124318 700
tf12 3851 100 9012 300 40000 11000 37000 9000 3851 100
tspline 11750 100 41000 300 73043 25000 90000 37000 11725 100
tscatter 26771 100 82724 3000 77792 25000 72945 24000 26771 100
Expand Down
Loading