[hist] Implement RHist{,Engine,Stats}::AddAtomic
#20418
Open
+330
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous code, the compiler would complain:
decltype cannot resolve address of overloaded function
For regular overloaded functions, it is possible to pass the expected
argument type (using std::declval), but not for member functions:
cannot call member function [...] without object
Instead use auto and trailing return type from C++11 to select the
right set of dispatch functions.
Test Results 22 files 22 suites 3d 17h 28m 52s ⏱️ Results for commit 1e7e4d9. ♻️ This comment has been updated with latest results. |
hageboeck
reviewed
Nov 14, 2025
hahnjo
force-pushed
the
hist-add-atomic
branch
from
a134024 to
1e7e4d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as building blocks for concurrent filling of
RHist.