Skip to content

Conversation

@jblomer
Copy link
Contributor

@jblomer jblomer commented Nov 10, 2025

The query methods IsCustomClass, IsCustomEnum, and IsStdAtomic are rather arbitrary and should not have been added to the public interface. They only make sense in the internal context in which they are used.

Removed for v6.42.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Test Results

    22 files      22 suites   3d 18h 28m 54s ⏱️
 3 779 tests  3 779 ✅ 0 💤 0 ❌
81 173 runs  81 173 ✅ 0 💤 0 ❌

Results for commit 134c7d5.

♻️ This comment has been updated with latest results.

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jblomer jblomer force-pushed the ntuple-deprecate-desc-helpers branch 2 times, most recently from 3333f53 to 134c7d5 Compare November 14, 2025 13:39
The query methods `IsCustomClass`, `IsCustomEnum`, and `IsStdAtomic` are
rather arbitrary and should not have been added to the public interface.
They only make sense in the internal context in which they are used.

Removed for v6.42.
@jblomer jblomer merged commit 9167c40 into root-project:master Nov 15, 2025
30 checks passed
@jblomer jblomer deleted the ntuple-deprecate-desc-helpers branch November 15, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants