-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[roottest] convert to cmake meta/ROOT-7181 tests #19676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -1,5 +1,5 @@ | |||
| .L lib/libjet.so | |||
| .L lib/libbtag.so | |||
| gSystem->Load("libjet_dictrflx"); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious, why those changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, .so is not working on Windows.
And second - use of .L libjet_dictrflx requires changes of default macro path.
So I trying to load library with gSystem->Load.
Test perfectly works on my node, but fails on all CI nodes.
So I need to investigate further
If that PR is already open and/or merged, can we link it here? |
Test Results 22 files 22 suites 4d 0h 42m 50s ⏱️ For more details on these failures, see this check. Results for commit ff2e051. ♻️ This comment has been updated with latest results. |
Change of cmsUnload is here: #19672 |
505dc61 to
c061944
Compare
e70cb3d to
fddf5b4
Compare
Like in cmsUnload, provide special runscript.C which loads commands and invoke them one by one.
Use of ProcessLine does not work on CI nodes
fddf5b4 to
6f822db
Compare
add missing entries in dictionary and use fully-qualified template class Actually it should not be required, by clang complains
|
Closing in favor of #20424 |
Like in cmsUnload, provide special runscript.C which loads commands and invoke them one by one.
Tests failing on most platforms with assert message from clang, to be investigated