Skip to content

[cernlib] avoid asan warning / maybe undefined behavior in h2root #19200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 2 commits into from
Oct 18, 2025
Merged

[cernlib] avoid asan warning / maybe undefined behavior in h2root #19200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db15655
[cernlib] avoid undefined behavior in h2root
ferdymercury Jun 26, 2025
9b628ac
[nfc] remove debug message
ferdymercury Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions misc/minicern/src/cernlib.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,17 @@ unsigned int lshift_(unsigned int *arg, int *len)
void vxinvb_(int *ixv, int *n)
{
int limit, jloop;
int in;
int out;
unsigned char *n1, *n2;
n2 = (unsigned char *) &out;
limit = *n;
for (jloop = 0; jloop < limit; jloop++) {
in = ixv[jloop];
ixv[jloop] =
((in >> 24) & 0x000000ff) |
((in >> 8) & 0x0000ff00) |
((in << 8) & 0x00ff0000) |
((in << 24) & 0xff000000);
n1 = (unsigned char *) &ixv[jloop];
n2[0] = n1[3];
n2[1] = n1[2];
n2[2] = n1[1];
n2[3] = n1[0];
ixv[jloop] = out;
}
return;
}
Expand All @@ -90,14 +92,17 @@ void vxinvb_(int *ixv, int *n)
void vxinvc_ (int *iv, int *ixv, int *n)
{
int limit, jloop;
int in;
int out;
unsigned char *n1, *n2;
n2 = (unsigned char *) &out;
limit = *n;
for (jloop = 0; jloop < limit; jloop++) {
in = iv[jloop];
ixv[jloop] =
((in >> 24) & 0x000000ff) |
((in >> 8) & 0x0000ff00) |
((in << 8) & 0x00ff0000) | ((in << 24) & 0xff000000);
n1 = (unsigned char *) &iv[jloop];
n2[0] = n1[3];
n2[1] = n1[2];
n2[2] = n1[1];
n2[3] = n1[0];
ixv[jloop] = out;
}
return;
}
Expand Down
Loading