Make various Legacy classes Nothrow_copyable #19102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,6 +78,9 @@ int TestVectors() | |||
| int TestVector3() { | |||
|
|
|||
| // test constructors: | |||
| static_assert(std::is_nothrow_copy_constructible_v<TVector3>); | |||
| static_assert(std::is_nothrow_copy_constructible_v<TVector2>); | |||
| static_assert(std::is_nothrow_copy_constructible_v<TLorentzRotation>); | |||
|
|
|||
There was a problem hiding this comment.
Thanks!
Other potential checks you coud add:
static_assert(std::is_nothrow_move_constructible_v);
static_assert(std::is_trivially_move_constructible_v);
static_assert(std::is_nothrow_move_assignable_v);
static_assert(std::is_trivially_move_assignable_v);
static_assert(std::is_trivially_copyable_v);
static_assert(std::is_trivially_destructible_v);
There was a problem hiding this comment.
These cannot be trivially anything because they depend on TObject.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Improves the type_trait deduction of various legacy classes. This provides performance benefits for composite objects in certain situations.
Add
static_assertsfor verificationNo documentation changes should be necessary
Changes or fixes:
Checklist:
This PR fixes #
#9042