Skip to content

[df] Remove dependency from RNTupleUtil in test #19098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[df] Remove dependency from RNTupleUtil in test #19098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tree/dataframe/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ ROOT_ADD_GTEST(dataframe_snapshot_emptyoutput dataframe_snapshot_emptyoutput.cxx
ROOT_GENERATE_DICTIONARY(DummyDict ${CMAKE_CURRENT_SOURCE_DIR}/DummyHeader.hxx
MODULE dataframe_snapshot_emptyoutput LINKDEF DummyHeaderLinkDef.hxx OPTIONS -inlineInputHeader
DEPENDENCIES ROOTVecOps GenVector)
ROOT_ADD_GTEST(dataframe_snapshot_ntuple dataframe_snapshot_ntuple.cxx LIBRARIES ROOTDataFrame ROOTNTupleUtil)
ROOT_ADD_GTEST(dataframe_snapshot_ntuple dataframe_snapshot_ntuple.cxx LIBRARIES ROOTDataFrame ROOTNTuple)
endif()

ROOT_ADD_GTEST(dataframe_datasetspec dataframe_datasetspec.cxx LIBRARIES ROOTDataFrame)
Expand Down
7 changes: 3 additions & 4 deletions tree/dataframe/test/dataframe_snapshot_ntuple.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#include "ROOT/RNTupleModel.hxx"
#include "ROOT/RNTupleWriter.hxx"
#include "ROOT/RNTupleReader.hxx"
#include "ROOT/RNTupleInspector.hxx" // For testing compression settings

#include "TROOT.h"
#include "TSystem.h"
Expand All @@ -17,7 +16,6 @@
using ROOT::RNTupleModel;
using ROOT::RNTupleReader;
using ROOT::RNTupleWriter;
using ROOT::Experimental::RNTupleInspector;

using namespace ROOT::RDF;

Expand Down Expand Up @@ -116,8 +114,9 @@ TEST(RDFSnapshotRNTuple, Compression)

EXPECT_EQ(columns, sdf->GetColumnNames());

auto inspector = RNTupleInspector::Create("ntuple", fileGuard.GetPath());
EXPECT_EQ(404, inspector->GetCompressionSettings());
auto reader = RNTupleReader::Open("ntuple", fileGuard.GetPath());
auto compSettings = *reader->GetDescriptor().GetClusterDescriptor(0).GetColumnRange(0).GetCompressionSettings();
EXPECT_EQ(404, compSettings);
}

class RDFSnapshotRNTupleTest : public ::testing::Test {
Expand Down
Loading