cling: Deduplicate lock code. Keep semantic distinction.

[pcanal]

LockCompilationDuringUserCodeExecutionRAII: to be used right before compiling/executing user code
InterpreterAccessRAII: to be used during loookups

[github-actions]

Test Results

    19 files      19 suites   3d 13h 56m 10s ⏱️
 2 748 tests  2 747 ✅ 0 💤 1 ❌
50 773 runs  50 772 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit bb3ca02.

♻️ This comment has been updated with latest results.

[hahnjo]

I don't really understand the semantic distinction between the two types: both access the interpreter and need to lock during compilation.

[pcanal]

The 'difference' is that the user-code related one is intended to be later temporarily suspended (via EnterUserCodeRAII) during the actual user code execution while the new usages are meant to be use in places where there is no user code being called and thus the lock will actually be held continuously by the thread until it is released by the RAII.

[hahnjo]

ok