[cmake] Add core/base headers to target HEADERS file_set #18419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 4d 0h 58m 57s ⏱️ Results for commit f85a692. ♻️ This comment has been updated with latest results. |
Member
|
Also potentially related: #17607 |
ferdymercury
commented
Apr 22, 2025
ferdymercury
commented
Apr 22, 2025
ferdymercury
force-pushed
the
cmakefileset
branch
from
e9a87ee to
347cde1
Compare
hageboeck
reviewed
Jul 17, 2025
Member
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
@ferdymercury, would you agree that the same can be achieved with less code, since CMake already does the expansion to absolute paths for us?
as suggested by hageboeck
Collaborator
Author
|
Simplification done! Btw this is the result in the GUI / IDE after this change: 
Unfolded: 
|
ferdymercury
changed the title
ferdymercury
added a commit
to ferdymercury/root
that referenced
this pull request
Sep 22, 2025
This version of CMake was released in March 2022 https://github.com/Kitware/CMake/releases/tag/v3.23.0 This version is required to use FILE_SETs, which could help towards root-project#16327 and root-project#18419.
ferdymercury
commented
Nov 21, 2025
guitargeek
approved these changes
Nov 24, 2025
ferdymercury
added a commit
to ferdymercury/root
that referenced
this pull request
Nov 25, 2025
This version of CMake was released in March 2022 https://github.com/Kitware/CMake/releases/tag/v3.23.0 This version is required to use FILE_SETs, which could help towards root-project#16327 and root-project#18419.
ferdymercury
added a commit
to ferdymercury/root
that referenced
this pull request
Nov 26, 2025
To improve IDE experience. See also root-project#18419 and root-project#20515
ferdymercury
added a commit
to ferdymercury/root
that referenced
this pull request
Nov 26, 2025
This version of CMake was released in March 2022 https://github.com/Kitware/CMake/releases/tag/v3.23.0 This version is required to use FILE_SETs, which could help towards root-project#16327 and root-project#18419. Since cmake_minimum_required updates the cmake_policy from 3.20 to 3.23, we need to take care of a change that happened from 3.20 to 3.21 that leads to an error in the CheckCompiler CMake module, so set the proper policy flag to old to avoid that error on some platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Gives a taste on how it would look like to properly add HEADERS to targets in CMake.
See also https://www.studyplan.dev/cmake/cmake-file-sets
This does not just help with the IDE workflow, it gives an idea on future paths:
One could make them PUBLIC instead of PRIVATE, then you would not need the target_include_directories line, and installing and cpacking would be easier.
Related:
Checklist:
This PR fixes #