Fixes for Mac beta #18265
Merged
Fixes for Mac beta #18265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hageboeck
force-pushed
the
TTRVA_initSizeBranch
branch
from
3dc9b65 to
44b7ac6
Compare
Test Results 19 files 19 suites 4d 14h 2m 14s ⏱️ For more details on these failures, see this check. Results for commit 2f653e4. ♻️ This comment has been updated with latest results. |
hageboeck
force-pushed
the
TTRVA_initSizeBranch
branch
3 times, most recently
from
2f653e4 to
b17085c
Compare
When changing trees while the missing value feature of RDF was in use, the proxies for branches could not get recreated, since TTreeReader refuses the registration when fProxiesSet == true. This lead to the TTreeReaderValue being in a broken state.
When running over multiple trees, the list of missing proxies in TTreeReader will grow indefinitely. Here, it is refactored to a set, which also shortens the code that looks up the missing proxies.
Pointed out by Philippe in root-project#18259.
In debugging a UB in TTreeReaderValueBase, it would have been easier to have an explicit note of the expected error messages of that test. Instead of globally suppressing all errors, the three expected message were added here.
On mac15 beta, this generated a SIGTRAP, while it was OK on all other platforms, because the reference was never used. But retrieving the pointer instead of dereferencing, the problem seems to go away.
Due to a missing quote, dependencies on Mac15 beta seemed to have gotten deleted.
hageboeck
force-pushed
the
TTRVA_initSizeBranch
branch
from
739ae7e to
2149b61
Compare
This was referenced Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: