[hist] revert changes to v5 GetExpFormula fl_format #18216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it breaks backward compatibility Fixes root-project#18214 thanks guitargeek for finding out
Test Results 18 files 18 suites 5d 0h 24m 2s ⏱️ For more details on these failures, see this check. Results for commit e814ac6. |
guitargeek
approved these changes
Apr 1, 2025
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thank you very much for the quick fixup!
guitargeek
added a commit
to guitargeek/root
that referenced
this pull request
Aug 24, 2025
In root-project#18194, an optional parameter to `TFormula::GetExpFormula()` was introduced, which can be used to customize the precision when putting parameters into the jitted code. However, I don't see the reason why wouldn't like to always print the floating point numbers with maximum precision, which is suggested in this commit. This is achieved using modern C++ functions, which are also not respecting the users locale setting, but instead use the classic C locale by default, which is what we need when generating code. Follows up on root-project#18194 (and its partial revert root-project#18216). Closes root-project#17225. Replaces root-project#17327.
guitargeek
added a commit
that referenced
this pull request
Aug 26, 2025
In #18194, an optional parameter to `TFormula::GetExpFormula()` was introduced, which can be used to customize the precision when putting parameters into the jitted code. However, I don't see the reason why wouldn't like to always print the floating point numbers with maximum precision, which is suggested in this commit. This is achieved using modern C++ functions, which are also not respecting the users locale setting, but instead use the classic C locale by default, which is what we need when generating code. Follows up on #18194 (and its partial revert #18216). Closes #17225. Replaces #17327.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert part of recent changes (#18194) since it breaks backward compatibility as the function was virtual.
Fixes #18214
thanks guitargeek for finding out
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #