[Python] Fix RDF Pythonization tests with builtin_llvm=OFF
#18192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 5d 4h 0m 37s ⏱️ For more details on these failures, see this check. Results for commit f89db46. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
numba_crash
branch
7 times, most recently
from
f7d13b1 to
2c0c142
Compare
guitargeek
force-pushed
the
numba_crash
branch
2 times, most recently
from
f89db46 to
fbe69e0
Compare
vepadulano
requested changes
Mar 31, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
That's unfortunate :( but I agree it wouldn't be the first time we see something like this and changing the test is ok. I left a minor comment
vepadulano
approved these changes
Mar 31, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thanks! Let's still wait for the CI to finish before merging
On my machine, the RDF pythonization tests don't run when I build ROOT with `builtin_llvm=OFF`. There is a crash unless I do `import numba` in the beginning. I guess it's not a priority to understand the underlying problem because not many people build ROOT like this and the workaround is easy, but at least the tests should be green. We do the same "magically ordered imports" also in other Python tests where ROOT doesn't work together with xgboost because of `std::regexp` symbol clashes, unless you do the import in a certain order: root-project#15183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine, the RDF pythonization tests don't run when I build ROOT with
builtin_llvm=OFF. There is a crash unless I doimport numbain the beginning.I guess it's not a priority to understand the underlying problem because not many people build ROOT like this and the workaround is easy, but at least the tests should be green.
We do the same "magically ordered imports" also in other Python tests where ROOT doesn't work together with xgboost because of
std::regexpsymbol clashes, unless you do the import in a certain order:#15183