Skip to content

Conversation

devajithvs
Copy link
Contributor

@devajithvs devajithvs commented Dec 5, 2024

This Pull request:

Adds a prototype implementation of SYCL support for standalone Cling. It works for standalone Cling, but is work in progress and is not ready for merge.

Changes or fixes:

Checklist:

  • Clone AdaptiveCpp git repo instead of adding the whole AdaptiveCpp codebase to CLING (like clad)
  • Clean up CMakeLists:
    • Currently, AdaptiveCpp is installed in a temporary directory to get include directories and acpp binaries for SYCL - now follows what is done for CLAD
  • Building with ROOT works now
  • Add test cases for SYCL
  • Investigate DPC++:
    • DPC++ does not currently support JIT

To build, you need the flag:
-Dexperimental_adaptivecpp

  • tested changes locally
  • updated the docs (if necessary)

Root's AdaptiveCpp fork (for static LLVM build and build-time usability - for genvectorx): https://github.com/root-project/AdaptiveCpp

Related: #18461

This PR fixes #

@devajithvs devajithvs self-assigned this Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

Test Results

    20 files      20 suites   3d 8h 47m 43s ⏱️
 3 092 tests  3 092 ✅ 0 💤 0 ❌
60 201 runs  60 201 ✅ 0 💤 0 ❌

Results for commit 85c3bb6.

♻️ This comment has been updated with latest results.

@devajithvs devajithvs force-pushed the dev.adaptivecpp-proto branch from 15fae9c to 5aefaee Compare January 15, 2025 09:00
@devajithvs devajithvs force-pushed the dev.adaptivecpp-proto branch from 5aefaee to 494d4db Compare January 28, 2025 13:45
@devajithvs devajithvs force-pushed the dev.adaptivecpp-proto branch from 494d4db to 9b03ea9 Compare March 16, 2025 20:52
@devajithvs devajithvs added in:Cling clean build Ask CI to do non-incremental build on PR labels Mar 16, 2025
@devajithvs devajithvs force-pushed the dev.adaptivecpp-proto branch from 8955d6e to d4e759f Compare March 18, 2025 14:36
@devajithvs devajithvs removed the clean build Ask CI to do non-incremental build on PR label Mar 18, 2025
@devajithvs devajithvs force-pushed the dev.adaptivecpp-proto branch 2 times, most recently from e8250a1 to bd3bc0f Compare March 21, 2025 16:48
@devajithvs devajithvs force-pushed the dev.adaptivecpp-proto branch from bd3bc0f to 93ce2ac Compare March 31, 2025 13:01
@devajithvs devajithvs changed the title [WIP] [cling] Prototype SYCL support for standalone cling [cling] Prototype SYCL support for standalone cling Apr 7, 2025
@devajithvs devajithvs force-pushed the dev.adaptivecpp-proto branch 5 times, most recently from 0a4d1e8 to 56e2fe3 Compare April 13, 2025 17:25
@devajithvs devajithvs force-pushed the dev.adaptivecpp-proto branch 5 times, most recently from 2bd1d8a to e29516a Compare June 9, 2025 13:07
@devajithvs devajithvs changed the title [cling] Prototype SYCL support for standalone cling [cling] Prototype SYCL support in ROOT Jun 9, 2025
@devajithvs devajithvs force-pushed the dev.adaptivecpp-proto branch from e29516a to 33c1c40 Compare June 9, 2025 13:10
@devajithvs devajithvs force-pushed the dev.adaptivecpp-proto branch from 33c1c40 to a12b1d4 Compare June 16, 2025 09:09
@devajithvs devajithvs force-pushed the dev.adaptivecpp-proto branch from a12b1d4 to 7a1a305 Compare June 16, 2025 09:14
@devajithvs devajithvs marked this pull request as ready for review June 16, 2025 17:48
@devajithvs devajithvs requested review from hahnjo and vgvassilev June 18, 2025 07:13
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting on the changes in interpreter/

@devajithvs devajithvs force-pushed the dev.adaptivecpp-proto branch from 7a1a305 to 85c3bb6 Compare July 2, 2025 08:46
@hahnjo
Copy link
Member

hahnjo commented Jul 4, 2025

LGTM for the interpreter/ changes. I didn't check the rest (CMake setup in particular)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants