[ntuple] Refactor RNTupleChainProcessor tests
#16874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a common test fixture for re-use of ntuple test files, and split a few tests into separate ones.
To avoid very long test files in the future, any `RNTupleChainProcessor`-related tests will live in a separate file. The same will be done for the `RNTupleJoinProcessor` (PR pending at the time of writing this commit message), reserving the `ntuple_processor.cxx` file name for tests that combine both.
Test Results 19 files 19 suites 4d 13h 55m 21s ⏱️ For more details on these failures, see this check. Results for commit 80f1d49. |
jblomer
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a common test fixture for re-use of ntuple test files, and splits a
few tests into separate ones. Additionally, the test file has been renamed to
ntuple_processor_chain.cxx. The same will be done for theRNTupleJoinProcessor(PR #16662), reserving thentuple_processor.cxxfile name for tests that combine the two.