Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] modularize geom and geombuilder #16514

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

silverweed
Copy link
Contributor

@silverweed silverweed commented Sep 24, 2024

This PR is a new attempt on #1166. It adds the geom and geombuilder modules, with:

  • geombuilder set OFF by default
  • geom set ON by default

Disabling geom also disables its dependant modules, i.e. Eve and gviz3d.

Related roottest PR: root-project/roottest#1190

Checklist:

  • tested changes locally

Copy link

github-actions bot commented Sep 24, 2024

Test Results

    14 files      14 suites   3d 4h 36m 25s ⏱️
 2 704 tests  2 704 ✅ 0 💤 0 ❌
35 594 runs  35 594 ✅ 0 💤 0 ❌

Results for commit d389015.

♻️ This comment has been updated with latest results.

Copy link
Member

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

geombuilder set OFF by default
geom set ON by default
@silverweed silverweed merged commit 28f895f into root-project:master Oct 1, 2024
20 checks passed
@silverweed silverweed deleted the cmake_geom branch October 1, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants