Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ntuple] fix treatment of "sharded cluster" flag #16511

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

jblomer
Copy link
Contributor

@jblomer jblomer commented Sep 23, 2024

Reserves the "sharded cluster" flag in the cluster summary but removes any additional s11n logic. Extends the cluster summary flags field to 8bits so that it can be handled with a standard C++ type.

Copy link

github-actions bot commented Sep 23, 2024

Test Results

    13 files      13 suites   2d 21h 0m 13s ⏱️
 2 697 tests  2 697 ✅ 0 💤 0 ❌
32 953 runs  32 953 ✅ 0 💤 0 ❌

Results for commit 995790c.

♻️ This comment has been updated with latest results.

Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jblomer jblomer merged commit 0550ae7 into root-project:master Sep 24, 2024
18 of 19 checks passed
@jblomer jblomer deleted the ntuple-fix-sharded-clusters branch September 24, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants