-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RF] Fixed tutorial ouputs and other imporvements to SBI tutorials #16509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsyr
force-pushed
the
dev_fix_tutorial
branch
from
September 26, 2024 14:42
da58cad
to
79c544d
Compare
Test Results 17 files 17 suites 4d 1h 49m 52s ⏱️ Results for commit 1fc5118. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
dev_fix_tutorial
branch
from
October 12, 2024 15:31
79c544d
to
f659367
Compare
guitargeek
requested review from
lmoneta,
dpiparo and
vepadulano
as code owners
October 12, 2024 15:31
This makes is finally efficient to define your pdfs in Python.
guitargeek
force-pushed
the
dev_fix_tutorial
branch
from
October 13, 2024 16:24
77da806
to
007654d
Compare
To do an extended fit and cache the precomputed LLR values, RooFit can be used directly.
guitargeek
force-pushed
the
dev_fix_tutorial
branch
from
October 13, 2024 16:39
007654d
to
034d76b
Compare
Like this, is will be easier for the users to adapt the formula to their use case.
Clearly mark the ownership of several raw pointers returned by function calls.
guitargeek
force-pushed
the
dev_fix_tutorial
branch
from
October 14, 2024 00:34
be1f506
to
7a7069e
Compare
guitargeek
changed the title
[RF] Fixed tutorial ouputs
[RF] Fixed tutorial ouputs and other imporvements to SBI tutorials
Oct 14, 2024
guitargeek
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed output by Morphing and SBI tutorials.